Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second parameter of Substring is wrong in HeaderFindAndReplaceCreator #1424

Merged
merged 7 commits into from
Sep 30, 2023
Merged

Second parameter of Substring is wrong in HeaderFindAndReplaceCreator #1424

merged 7 commits into from
Sep 30, 2023

Commits on Sep 30, 2023

  1. Update HeaderFindAndReplaceCreator.cs 

    Second parameter of Substring was wrong. Existing implementation works only for replacements at the beginning of a string (startOfPlaceholder = 0)
    @fku- @raman-m
    fku- authored and raman-m committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    10bfc0a View commit details
    Browse the repository at this point in the history

  2. Update HeaderFindAndReplaceCreator.cs 

    Remove and Sort Usings
    @raman-m
    raman-m committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    817a800 View commit details
    Browse the repository at this point in the history

  3. Update HeaderFindAndReplaceCreator.cs: Replace by char 

    Co-authored-by: Raynald Messié <[email protected]>
    @raman-m @RaynaldM
    raman-m and RaynaldM committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    dd1f9ab View commit details
    Browse the repository at this point in the history

  4. Update HeaderFindAndReplaceCreator.cs: Split by char

    @raman-m
    raman-m committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    d32f4e4 View commit details
    Browse the repository at this point in the history

  5. Review

    @raman-m
    raman-m committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    2a8815c View commit details
    Browse the repository at this point in the history

  6. Fix 'length' value for 'Substring' 2nd param

    @raman-m
    raman-m committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    3d799d3 View commit details
    Browse the repository at this point in the history

  7. Add unit test to check replacements in the middle

    @raman-m
    raman-m committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    dd52248 View commit details
    Browse the repository at this point in the history