Second parameter of Substring is wrong in HeaderFindAndReplaceCreator #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefancruz
pushed a commit
to stefancruz/Ocelot
that referenced
this pull request
Dec 22, 2022
Second parameter of Substring was wrong. Existing implementation works only for replacements at the beginning of a string (startOfPlaceholder = 0) Cherry picked from ThreeMammals#1424
raman-m
changed the title
|
Related to |
|
@fku- Hi Freddy! The feature branch has been rebased onto ThreeMammals:develop! I see that develop branch in your fork is old. Is the PR related to an issue in backlog? |
raman-m
requested review from
binarymash,
jps,
geffzhang,
RaynaldM,
philproctor,
anktsrkr,
sharpn,
abooraja,
wast,
yangzhongke and
thiagoloureiro
RaynaldM
previously approved these changes
Aug 23, 2023
src/Ocelot/Configuration/Creator/HeaderFindAndReplaceCreator.cs
Outdated
Show resolved
Hide resolved
raman-m
requested changes
Sep 30, 2023
src/Ocelot/Configuration/Creator/HeaderFindAndReplaceCreator.cs
Outdated
Show resolved
Hide resolved
Second parameter of Substring was wrong. Existing implementation works only for replacements at the beginning of a string (startOfPlaceholder = 0)
Remove and Sort Usings
Co-authored-by: Raynald Messié <[email protected]>
raman-m
previously approved these changes
Sep 30, 2023
raman-m
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second parameter of
Substringwas wrong: calculation of value for theint lengthparameter was wrong.Existing implementation works only for replacements at the beginning of a string
startOfPlaceholder = 0.Proposed Changes