forked from OCA/sale-workflow
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] sale_global_discount: refactor _compute_amounts #2
Open
trisdoan
wants to merge
189
commits into
Studio73:16.0-mig-sale_global_discount
Choose a base branch
from
trisdoan:16.0-imp-sale_global_discount
base: 16.0-mig-sale_global_discount
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[16.0][IMP] sale_global_discount: refactor _compute_amounts #2
trisdoan
wants to merge
189
commits into
Studio73:16.0-mig-sale_global_discount
from
trisdoan:16.0-imp-sale_global_discount
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trisdoan
force-pushed
the
16.0-imp-sale_global_discount
branch
from
June 11, 2024 09:11
9b79506
to
55e64dc
Compare
santostelmo
approved these changes
Jun 12, 2024
trisdoan
force-pushed
the
16.0-imp-sale_global_discount
branch
from
June 13, 2024 07:13
55e64dc
to
c232b83
Compare
ferran-S73
force-pushed
the
16.0-mig-sale_global_discount
branch
2 times, most recently
from
June 20, 2024 06:55
54cdf29
to
ded6836
Compare
Currently translated at 85.7% (6 of 7 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_force_invoiced/hr/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_price_recalculation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_price_recalculation/hr/
Currently translated at 79.5% (35 of 44 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_advance_payment Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_advance_payment/hr/
Currently translated at 100.0% (7 of 7 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_auto_remove_zero_quantity_lines Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_auto_remove_zero_quantity_lines/hr/
Currently translated at 100.0% (7 of 7 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-product_form_sale_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-product_form_sale_link/hr/
Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_automatic_workflow_payment_mode/hr/
Currently translated at 100.0% (7 of 7 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_shipping_info_helper Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_shipping_info_helper/hr/
Currently translated at 100.0% (9 of 9 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_delivery_state Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_delivery_state/hr/
Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_mrp_bom Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_mrp_bom/hr/
Currently translated at 100.0% (7 of 7 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_carrier_auto_assign Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_carrier_auto_assign/hr/
Currently translated at 100.0% (1 of 1 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_procurement_customer Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_procurement_customer/hr/
Currently translated at 18.6% (11 of 59 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_automatic_workflow Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_automatic_workflow/hr/
Currently translated at 100.0% (26 of 26 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/it/
Currently translated at 100.0% (170 of 170 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_blanket_order Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_blanket_order/it/
If test is run at a certain date nearly midnight, the test that evaluates invoice date from sale one was failing. So, freeze the date at mid of day.
Currently translated at 100.0% (6 of 6 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_force_invoiced_quantity Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_force_invoiced_quantity/it/
Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_partner_no_autofollow Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_partner_no_autofollow/it/
…e based on product uom qty
trisdoan
force-pushed
the
16.0-imp-sale_global_discount
branch
from
August 29, 2024 04:35
bfbd0f2
to
66e7eb4
Compare
trisdoan
force-pushed
the
16.0-imp-sale_global_discount
branch
from
August 29, 2024 10:46
66e7eb4
to
751459b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In simple case (tax is not included in price), flow of the module as follow:
A example of Sale order is below:
=> So tax is recalculated based on Final price (after global discount)
This change
pass param:
handle_price_include=False
because it was handle in super(), by defaulthandle_price_include=True
. Now, as we recalculate tax to apply global discount, there is no need to handle price included or not.With above example, now it is:
- but this time, Tax is included in price