Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] sale_global_discount: 16.0 #2343

Merged
merged 38 commits into from
Jun 28, 2024
Merged

[16.0][MIG] sale_global_discount: 16.0 #2343

merged 38 commits into from
Jun 28, 2024

Conversation

ferran-S73
Copy link
Contributor

@ferran-S73 ferran-S73 commented Jan 20, 2023 •
edited
Loading

@ferran-S73 ferran-S73 mentioned this pull request Jan 20, 2023
Open
98 tasks
@rousseldenis
Copy link
Contributor

/ocabot migration sale_global_discount

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jan 25, 2023
@rousseldenis
Copy link
Contributor

@ferran-S73 Thanks for this. FYI, you can follow the following guide in order to integrate temporary requirements in order to be able to test it on runboat

https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

@ferran-S73
Copy link
Contributor Author

@ferran-S73 Thanks for this. FYI, you can follow the following guide in order to integrate temporary requirements in order to be able to test it on runboat

https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

@rousseldenis done, thanks for the tip!

@ferran-S73
Copy link
Contributor Author

@rousseldenis I'm not sure I'm doing it right, could you please check if the dependencies are correctly added?

@rousseldenis
Copy link
Contributor

@rousseldenis I'm not sure I'm doing it right, could you please check if the dependencies are correctly added?

@ferran-S73 It seems yes as runboat is started but tests are failing

@rousseldenis
Copy link
Contributor

@ferran-S73

@ferran-S73
Copy link
Contributor Author

@ferran-S73

I haven't been able to figure out why my tests env isn't behaving like my local Odoo env. I seem to have a problem (in the tests only) in which instead of recalculating the tax line another one is added.
I'm gonna need more time to fix this issue

@BT-srieskamp
Copy link

Hi @ferran-S73 , I am curious about the current state of this migration. Do you see it possible to get it merged soon?

Kind Regards,
Sarah

@ferran-S73
Copy link
Contributor Author

Hi @ferran-S73 , I am curious about the current state of this migration. Do you see it possible to get it merged soon?

Kind Regards, Sarah

Hi @BT-skettler I'm having trouble fixing the tests for account_global_discount so it will still be a little until I merge them both. Sorry for the inconvenience!

@ferran-S73 ferran-S73 force-pushed the 16.0-mig-sale_global_discount branch 6 times, most recently from cc611a7 to 7d86e29 Compare May 22, 2023 09:11
@ferran-S73 ferran-S73 force-pushed the 16.0-mig-sale_global_discount branch 2 times, most recently from 67d4e19 to cdf5cee Compare June 19, 2023 13:31
@ferran-S73 ferran-S73 force-pushed the 16.0-mig-sale_global_discount branch from b64ca36 to 3be8831 Compare June 28, 2023 16:55
QuocDuong1306
QuocDuong1306 approved these changes Aug 28, 2023
View reviewed changes
Copy link

@QuocDuong1306 QuocDuong1306 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cyrilmanuel
cyrilmanuel approved these changes Aug 31, 2023
View reviewed changes
Copy link

@cyrilmanuel cyrilmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not an expert but LGTM

francesco-ooops and others added 10 commits June 20, 2024 08:54
@francesco-ooops @ferran-S73
Translated using Weblate (Italian)
72836b3 
Currently translated at 100.0% (13 of 13 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_global_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_global_discount/it/
@tafaRU @ferran-S73
[IMP] sale_global_discount: improve README with reference to the one …
ebc01f3 
…of base_global_discount

In this way we also include the following configuration step:
* Go to *Settings > Users*, choose yours and set *Manage Global Discounts*

Without this *Global Discounts* doesn't show up!
@OCA-git-bot @ferran-S73
[UPD] README.rst
55f5f87
@OCA-git-bot @ferran-S73
sale_global_discount 14.0.1.1.0
3ceeab6
@kirca @ferran-S73
sale_global_discount: Migration to 15.0
8e1dd2e
@kirca @ferran-S73
[FIX] sale_global_discount: compute the taxes widget with global disc…
32f60aa 
…ounts applied
@ferran-S73
[IMP] sale_global_discount: black, isort, prettier
a6e38a2
@ferran-S73
[MIG] sale_global_discount: 16.0
8e464a8
@Rferri44-S73 @ferran-S73
[16.0][IMP] sale_global_discount: Remake amount global discount
257971e
@ChrisOForgeFlow @ferran-S73
[14.0][IMP] sale_global_discount, added init hook to avoid memory iss…
ded6836 
…ues on big database installation
@ferran-S73 ferran-S73 force-pushed the 16.0-mig-sale_global_discount branch 2 times, most recently from 54cdf29 to ded6836 Compare June 20, 2024 06:55
@mariancuadranetkia
Copy link

@ferran-S73 thanks! I tested it in runboat and LGTM :)
@rousseldenis do you think it still needs some revision?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@alvaro-domatix
Copy link

Hello @pedrobaeza , could you merge this PR when you have a moment? Thanks.

@pedrobaeza pedrobaeza changed the title [MIG] sale_global_discount: 16.0 [16.0][MIG] sale_global_discount: 16.0 Jun 28, 2024
@pedrobaeza
Copy link
Member

Merging following the reviews:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2343-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 562c4e8 into OCA:16.0 Jun 28, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9330c48. Thanks a lot for contributing to OCA. ❤️

This was referenced Jun 28, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GasparJarsa GasparJarsa GasparJarsa left review comments

@QuocDuong1306 QuocDuong1306 QuocDuong1306 approved these changes

@alvaro-domatix alvaro-domatix alvaro-domatix approved these changes

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

@leemannd leemannd leemannd approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.