🐛 defer unlocking of mutex #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defer works even when there's a panic so we are always unlocking the mutex. Signed-off-by: kranurag7 <[email protected]>
chess-knight
added a commit
to SovereignCloudStack/cluster-stack-provider-openstack
that referenced
this pull request
Feb 16, 2024
Based on SovereignCloudStack/cluster-stack-operator#70 Signed-off-by: Roman Hros <[email protected]>
3 tasks
janiskemper
approved these changes
Feb 16, 2024
chess-knight
approved these changes
Feb 16, 2024
chess-knight
added a commit
to SovereignCloudStack/cluster-stack-provider-openstack
that referenced
this pull request
Feb 16, 2024
* Create GitHub client only if it is necessary Fixes #80 Signed-off-by: Roman Hros <[email protected]> * Defer unlocking of mutex Based on SovereignCloudStack/cluster-stack-operator#70 Signed-off-by: Roman Hros <[email protected]> * Create a GitHub client before mutex Signed-off-by: Roman Hros <[email protected]> --------- Signed-off-by: Roman Hros <[email protected]>
jschoone
added
the
Container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defer works even when there's a panic so we are
always unlocking the mutex.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #69
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: