Merge pull request #70 from SovereignCloudStack/kr/defer-mutex

🐛 defer unlocking of mutex
SovereignCloudStack · Apr 24, 2024 · d7a944d · d7a944d
2 parents 35d657a + 14f2e8c
commit d7a944d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/internal/controller/clusterstackrelease_controller.go b/internal/controller/clusterstackrelease_controller.go
@@ -113,6 +113,8 @@ func (r *ClusterStackReleaseReconciler) Reconcile(ctx context.Context, req recon
 		// acquire lock so that only one reconcile loop can download the release
 		r.clusterStackRelDownloadDirectoryMutex.Lock()
 
+		defer r.clusterStackRelDownloadDirectoryMutex.Unlock()
+
 		gc, err := r.GitHubClientFactory.NewClient(ctx)
 		if err != nil {
 			conditions.MarkFalse(clusterStackRelease,
@@ -131,8 +133,6 @@ func (r *ClusterStackReleaseReconciler) Reconcile(ctx context.Context, req recon
 			return reconcile.Result{}, fmt.Errorf("failed to download release assets: %w", err)
 		}
 
-		r.clusterStackRelDownloadDirectoryMutex.Unlock()
-
 		// requeue to make sure release assets can be accessed
 		return reconcile.Result{Requeue: true}, nil
 	}