Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(renterd): contract total cost initial renter funds #840

Open
wants to merge 1 commit into
base: feat_hostd_contracts_multi-select_and_bulk_integrity_check
Choose a base branch
from

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Nov 27, 2024

  • The contract total cost value is now called initial renter funds.

Screenshot 2024-11-27 at 5.01.42 PM.png

Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: 16982bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
renterd Minor
@siafoundation/renterd-js Minor
@siafoundation/renterd-react Minor
@siafoundation/renterd-types Minor
@siafoundation/clusterd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
renterd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 8:27pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 8:27pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 8:27pm
hostd ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 8:27pm
website ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 8:27pm

@@ -320,7 +320,7 @@ export type ContractsAddParams = {
export type ContractsAddPayload = {
contract: ContractRevision
startHeight: number
totalCost: Currency
initialRenterFunds: Currency
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterjan was this field also renamed in the contracts add and renew endpoint payloads?

@alexfreska alexfreska force-pushed the feat_hostd_contracts_multi-select_and_bulk_integrity_check branch from 8cdd612 to fdc456e Compare December 2, 2024 20:22
@alexfreska alexfreska force-pushed the refactor_renterd_contract_total_cost_initial_renter_funds branch from 48995db to 16982bf Compare December 2, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant