Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(renterd): hosts multi-select and batch manage blocklist and allowlist #829

Open
wants to merge 1 commit into
base: feat_renterd_contracts_batch_manage_blocklist_and_allowlist
Choose a base branch
from
Open

feat(renterd): hosts multi-select and batch manage blocklist and allowlist #829

wants to merge 1 commit into from
+641 −266

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Nov 22, 2024 •
edited
Loading

  • The hosts multi-select menu now supports bulk adding and removing to both the allowlist and blocklists.
  • The hosts table now supports multi-select.
  • The host map must now be explicitly toggled open with the action button in the navbar.

Notes

  • This PR makes the bulk action components introduced in parent PR into generic components that can be used in both the host and contract contexts.

Screenshot 2024-11-27 at 10.11.38 AM.png

@vercel Vercel
Copy link

vercel bot commented Nov 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
renterd 🛑 Canceled (Inspect) Nov 27, 2024 4:40pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 4:40pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 4:40pm
hostd ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 4:40pm
website ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 4:40pm

This was referenced Nov 22, 2024
Open
Merged
Open
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 5a0eca2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
renterd Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This was referenced Nov 22, 2024
Merged
Merged
@alexfreska Graphite App
Copy link
Member Author

alexfreska commented Nov 22, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@alexfreska alexfreska mentioned this pull request Nov 22, 2024
Merged
@alexfreska alexfreska force-pushed the feat_renterd_contracts_batch_manage_blocklist_and_allowlist branch from f461c6e to b2204f2 Compare November 22, 2024 22:19
@alexfreska alexfreska force-pushed the feat_renterd_hosts_multi-select_and_batch_manage_blocklist_and_allowlist branch from 02ce9f3 to 546e10a Compare November 22, 2024 22:19
@alexfreska alexfreska force-pushed the feat_renterd_contracts_batch_manage_blocklist_and_allowlist branch from b2204f2 to 617c9cf Compare November 26, 2024 15:35
@alexfreska alexfreska force-pushed the feat_renterd_hosts_multi-select_and_batch_manage_blocklist_and_allowlist branch from 546e10a to b7384eb Compare November 26, 2024 15:35
@alexfreska alexfreska mentioned this pull request Nov 26, 2024
Open
@alexfreska alexfreska force-pushed the feat_renterd_contracts_batch_manage_blocklist_and_allowlist branch from 617c9cf to a45141f Compare November 26, 2024 16:06
@alexfreska alexfreska force-pushed the feat_renterd_hosts_multi-select_and_batch_manage_blocklist_and_allowlist branch from b7384eb to 0eac87b Compare November 26, 2024 16:06
This was referenced Nov 26, 2024
Open
Open
@alexfreska alexfreska mentioned this pull request Nov 26, 2024
Open
@alexfreska alexfreska force-pushed the feat_renterd_contracts_batch_manage_blocklist_and_allowlist branch from a45141f to 3801cd1 Compare November 27, 2024 14:42
@alexfreska alexfreska force-pushed the feat_renterd_hosts_multi-select_and_batch_manage_blocklist_and_allowlist branch from 0eac87b to c9858f5 Compare November 27, 2024 14:43
@alexfreska alexfreska mentioned this pull request Nov 27, 2024
Open
@alexfreska alexfreska force-pushed the feat_renterd_contracts_batch_manage_blocklist_and_allowlist branch from 3801cd1 to 3775692 Compare November 27, 2024 14:53
@alexfreska alexfreska force-pushed the feat_renterd_hosts_multi-select_and_batch_manage_blocklist_and_allowlist branch from c9858f5 to c2b9f0a Compare November 27, 2024 14:54
@alexfreska alexfreska force-pushed the feat_renterd_contracts_batch_manage_blocklist_and_allowlist branch from 3775692 to ac5e83f Compare November 27, 2024 15:48
@alexfreska alexfreska force-pushed the feat_renterd_hosts_multi-select_and_batch_manage_blocklist_and_allowlist branch from c2b9f0a to 33e87a8 Compare November 27, 2024 15:48
@alexfreska alexfreska force-pushed the feat_renterd_contracts_batch_manage_blocklist_and_allowlist branch from ac5e83f to e335641 Compare November 27, 2024 15:52
@alexfreska alexfreska force-pushed the feat_renterd_hosts_multi-select_and_batch_manage_blocklist_and_allowlist branch from 33e87a8 to 1664695 Compare November 27, 2024 15:52
@alexfreska alexfreska force-pushed the feat_renterd_contracts_batch_manage_blocklist_and_allowlist branch from e335641 to 588f58d Compare November 27, 2024 16:11
@alexfreska alexfreska force-pushed the feat_renterd_hosts_multi-select_and_batch_manage_blocklist_and_allowlist branch from 1664695 to 76146f3 Compare November 27, 2024 16:11
@alexfreska alexfreska force-pushed the feat_renterd_contracts_batch_manage_blocklist_and_allowlist branch from 588f58d to e3b3ff2 Compare November 27, 2024 16:26
@alexfreska alexfreska force-pushed the feat_renterd_hosts_multi-select_and_batch_manage_blocklist_and_allowlist branch from 76146f3 to 5a0eca2 Compare November 27, 2024 16:26
This was referenced Nov 27, 2024
Open
Open
Open
Open
peterjan
peterjan reviewed Dec 2, 2024
View reviewed changes
libs/renterd-types/src/bus.ts
@@ -268,7 +268,7 @@ export type HostsBlocklistUpdatePayload = {
export type HostsBlocklistUpdateResponse = void

export type HostResetLostSectorCountParams = {
publicKey: string
publickey: string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this caught my eye, these routes have the hostkey as path param but don't require anything in the request body

		"GET    /host/:hostkey":                  b.hostsPubkeyHandlerGET,
		"PUT    /host/:hostkey/check":            b.hostsCheckHandlerPUT,
		"POST   /host/:hostkey/resetlostsectors": b.hostsResetLostSectorsPOST,
		"POST   /host/:hostkey/scan":             b.hostsScanHandlerPOST,

peterjan
peterjan approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjan peterjan peterjan approved these changes

@telestrial telestrial Awaiting requested review from telestrial

Assignees

@alexfreska alexfreska

Labels
None yet
Projects
Sia
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexfreska @peterjan