Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been using
LexErrorList
as the lexer for the CodeLite's terminal emulator. I noticed some problems, mainly because thediff
styling assumptions are a bit "aggressive": If a line starts with-
then it is probably the output ofgit diff
ordiff ..
command. This is true for many cases, but there are cases where this can be improved a bit.Two case that I noticed:
ls -l
command and the entry does not has theexecute
permission, then it will start with-
cmake
and the output produces CMake's status message (generated by cmake'smessage(STATUS "something")
callsI have added 4 screenshots, 2 showing the problems before the fix, and 2 after the fix
ls -la
output lines starting with-r
are styled as "DIFF_DELETE"After the fix: