ErrorList lexer fixes #3
Open
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Better handling of CMake status messages With the current handling, lines starting with "-" are considered "Diff deleted" message except for lines starting with "---" which are considered as "Diff message". A common line is also the CMake status lines which generate lines starting with "--". This fix handles them as "normal" lines and not has "Diff deleted" lines - Exclude output of the command "ls -l" from labeled as "Diff deleted" lines A common output for the "ls -l" command are lines with a similar pattern to: `-rw-r--r-- 1 user user 80864 Nov 4 23:35 file.cpp` These lines are mistakenly considered as "Diff deleted" lines - this commit fixes this behavior Signed-off-by: Eran Ifrah <[email protected]>
|
Thanks, but is this change already present upstream? It would be nice to avoid diverging from it more than strictly necessary. |
|
I was not sure if this fork is aligned with the official one, I can post it there as well |
|
Posted a PR for Lexilla as well: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMakestatus messagesWith the current handling, lines starting with
-are considered "Diff deleted" message except for lines starting with---which are considered as "Diff message". A common pattern are the status line generated byCMake. These lines are starting with--. This fix handles them as "normal" lines and not has "Diff deleted" linesls -loutputA common output for the
ls -lcommand are lines with a similar pattern to:These lines are mistakenly considered as "Diff deleted" lines (due to the
-at the start) - this commit fixes this behavior