Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow PartialPermutation to accept empty vector #22229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow PartialPermutation to accept empty vector #22229

wants to merge 1 commit into from

Conversation

xuchenhan-tri
Copy link
Contributor

@xuchenhan-tri xuchenhan-tri commented Nov 22, 2024 •
edited by sherm1
Loading

Prevents segfaulting when constructing PartialPermutation with an empty std::vector.

This change is Reviewable

@xuchenhan-tri xuchenhan-tri added the release notes: none This pull request should not be mentioned in the release notes label Nov 22, 2024
xuchenhan-tri
xuchenhan-tri commented Nov 22, 2024
View reviewed changes
Copy link
Contributor Author

@xuchenhan-tri xuchenhan-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@amcastro-tri for feature review please.

Reviewable status: LGTM missing from assignee amcastro-tri, needs platform reviewer assigned, needs at least two assigned reviewers

amcastro-tri
amcastro-tri reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@amcastro-tri amcastro-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers

xuchenhan-tri
xuchenhan-tri commented Nov 26, 2024
View reviewed changes
Copy link
Contributor Author

@xuchenhan-tri xuchenhan-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@sammy-tri for platform review on Monday per rotation please.

Reviewable status: LGTM missing from assignee sammy-tri(platform)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcastro-tri amcastro-tri amcastro-tri left review comments

Assignees

@sammy-tri sammy-tri

@amcastro-tri amcastro-tri

Labels
release notes: none This pull request should not be mentioned in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuchenhan-tri @amcastro-tri @sammy-tri