-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide nicer error messages on misuse of the library #8
Open
Quincunx271
wants to merge
8
commits into
main
Choose a base branch
from
warn-or-error-on-misuse
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jan 6, 2021
-
Warn about forgetting to invoke void function
If the user forgets the final `()` to invoke the function, they will now receive a warning. This is only relevant for void-returning functions where the result is not otherwise stored. For functions which return a value, this is both impossible to check and unnecessary, because they will probably receive other compile errors down the line.
Configuration menu - View commit details
-
Copy full SHA for 8a35362 - Browse repository at this point
Copy the full SHA 8a35362View commit details -
Configuration menu - View commit details
-
Copy full SHA for e312ab3 - Browse repository at this point
Copy the full SHA e312ab3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e79510 - Browse repository at this point
Copy the full SHA 2e79510View commit details -
Configuration menu - View commit details
-
Copy full SHA for d86cd26 - Browse repository at this point
Copy the full SHA d86cd26View commit details -
Configuration menu - View commit details
-
Copy full SHA for e24f684 - Browse repository at this point
Copy the full SHA e24f684View commit details
Commits on Jan 7, 2021
-
Silence irrelevant Clang warnings about C++Future
Even though we used feature-test macros, Clang emitted warnings about using features from C++Future. This change silences those warnings by using _Pragma to ignonre the particular warning flag for only the offending constructs. This requires quite a bit of compiler detection preprocessor code, but short of Clang getting its act together with these warnings around feature-test macros, there's not much else we can realistically do.
Configuration menu - View commit details
-
Copy full SHA for 12d5494 - Browse repository at this point
Copy the full SHA 12d5494View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07a2f47 - Browse repository at this point
Copy the full SHA 07a2f47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3772aa0 - Browse repository at this point
Copy the full SHA 3772aa0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.