Provide nicer error messages on misuse of the library #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user forgets the final `()` to invoke the function, they will now receive a warning. This is only relevant for void-returning functions where the result is not otherwise stored. For functions which return a value, this is both impossible to check and unnecessary, because they will probably receive other compile errors down the line.
Even though we used feature-test macros, Clang emitted warnings about using features from C++Future. This change silences those warnings by using _Pragma to ignonre the particular warning flag for only the offending constructs. This requires quite a bit of compiler detection preprocessor code, but short of Clang getting its act together with these warnings around feature-test macros, there's not much else we can realistically do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.