Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver metadata validation #220

Closed
wants to merge 6 commits into from
Closed

Conversation

kalsky
Copy link
Contributor

@kalsky kalsky commented Sep 25, 2018

Description

adds validations between the driver.py and the drivermetadata.xml to make sure the metadata only mentions existing functions.

Related Stories

#182

Breaking

NO


This change is Reviewable

if a function exists/mentioned in the metadata but does not exist in the driver, an error will be shown with the list of functions.
The other way is ok (have a function in the driver.py that do not exist in the metadata).
click 7.0 was released, progressbar.next() is not supported anymore. other things might not work as well and should be tested.
@coveralls
Copy link

coveralls commented Sep 26, 2018

Coverage Status

Coverage increased (+0.2%) to 85.815% when pulling c97054f on driver-metadata-validation into 85a5576 on master.

as in the master
@kalsky kalsky requested a review from alexquali October 5, 2018 17:10
@GalcQuali
Copy link

Hi Yaniv,

Currently we will not implement automatic removal of the commands from the metadata.
However, we will make sure to improve/emphasis this in the dev guide.

Thanks,
Gal.

@GalcQuali GalcQuali closed this Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants