Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add driver validations - compare to the driver metadata #182

Open
kalsky opened this issue Oct 17, 2017 · 1 comment
Open

add driver validations - compare to the driver metadata #182

kalsky opened this issue Oct 17, 2017 · 1 comment

Comments

@kalsky
Copy link
Contributor

kalsky commented Oct 17, 2017

Issue details

When the driver metadata is refering to commands that do not exist in the driver.py, end with a relevant error the pack/install commands of the shellfoundry to prevent issues later on (commands will not be available, etc).

Steps to reproduce

have a few commands in the driver.py and more/different commands in the driver metadata file.
run shellfoundry pack
return errors about missing commands (ones that exist in the metadata and not in the driver.py - the other way is ok)

@GalcQuali
Copy link

Hi Yaniv,

Currently we will not implement automatic removal of the commands from the metadata.
However, we will make sure to improve/emphasis this in the dev guide.

Thanks,
Gal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants