Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error and add qt5 support #10

Merged
merged 4 commits into from
Sep 5, 2017
Merged

Fix build error and add qt5 support #10

merged 4 commits into from
Sep 5, 2017

Commits on Sep 4, 2017

  1. COMP: Update minimum required CMake version to match Slicer requirements 

    This commit updates the required version to 3.5
    @jcfr
    jcfr committed Sep 4, 2017
    Configuration menu
    Copy the full SHA
    bd6def9 View commit details
    Browse the repository at this point in the history

  2. COMP: Fix dcmtk includes in itkDCMTKFileReader 

    This commit fixes error like the following:

```
In file included from /tmp/LongitudinalPETCT/Quantification/PETSUVImageMaker/PETSUVImageMaker.cxx:41:0:
/tmp/LongitudinalPETCT/Quantification/PETSUVImageMaker/itkDCMTKFileReader.h:26:20: fatal error: dcxfer.h: No such file or directory
```
    @jcfr
    jcfr committed Sep 4, 2017
    Configuration menu
    Copy the full SHA
    a363347 View commit details
    Browse the repository at this point in the history

  3. COMP: Fix build error associated with vtkMRMLLongitudinalPETCTStudyNode 

    This commit fixes the following build error by removing code trying to
associate transform with the volume property node.

Following r24891 (ENH: Moved up vtkMRMLStorableNode in the MRML node
hierarchy.), vtkMRMLStorableNode is not a children of vtkMRMLTransformable
node anymore, but directly a children of vtkMRMLNode.

This commit fixes the following error:

```
/tmp/LongitudinalPETCT/MRML/vtkMRMLLongitudinalPETCTStudyNode.cxx: In member function ‘void vtkMRMLLongitudinalPETCTStudyNode::ObserveRegistrationTransform(bool)’:
/tmp/LongitudinalPETCT/MRML/vtkMRMLLongitudinalPETCTStudyNode.cxx:478:28: error: ‘class vtkMRMLVolumePropertyNode’ has no member named ‘GetParentTransformNode’
               && propNode->GetParentTransformNode()
                            ^
/tmp/LongitudinalPETCT/MRML/vtkMRMLLongitudinalPETCTStudyNode.cxx:480:23: error: ‘class vtkMRMLVolumePropertyNode’ has no member named ‘SetAndObserveTransformNodeID’
             propNode->SetAndObserveTransformNodeID(
                       ^
/tmp/LongitudinalPETCT/MRML/vtkMRMLLongitudinalPETCTStudyNode.cxx:503:23: error: ‘class vtkMRMLVolumePropertyNode’ has no member named ‘SetAndObserveTransformNodeID’
             propNode->SetAndObserveTransformNodeID(NULL);
                       ^
```
    @jcfr
    jcfr committed Sep 4, 2017
    Configuration menu
    Copy the full SHA
    1b42eef View commit details
    Browse the repository at this point in the history

  4. COMP: Qt5: Fix error: static assertion failed: Old plugin system used 

    See https://www.slicer.org/wiki/Documentation/Labs/Qt5-and-VTK8#Qt5:_Update_loadable_modules_to_use_new_plugin_macros
    @jcfr
    jcfr committed Sep 4, 2017
    Configuration menu
    Copy the full SHA
    bd17d7b View commit details
    Browse the repository at this point in the history