Fix build error and add qt5 support #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the required version to 3.5
This commit fixes error like the following: ``` In file included from /tmp/LongitudinalPETCT/Quantification/PETSUVImageMaker/PETSUVImageMaker.cxx:41:0: /tmp/LongitudinalPETCT/Quantification/PETSUVImageMaker/itkDCMTKFileReader.h:26:20: fatal error: dcxfer.h: No such file or directory ```
This commit fixes the following build error by removing code trying to
associate transform with the volume property node.
Following r24891 (ENH: Moved up vtkMRMLStorableNode in the MRML node
hierarchy.), vtkMRMLStorableNode is not a children of vtkMRMLTransformable
node anymore, but directly a children of vtkMRMLNode.
This commit fixes the following error:
```
/tmp/LongitudinalPETCT/MRML/vtkMRMLLongitudinalPETCTStudyNode.cxx: In member function ‘void vtkMRMLLongitudinalPETCTStudyNode::ObserveRegistrationTransform(bool)’:
/tmp/LongitudinalPETCT/MRML/vtkMRMLLongitudinalPETCTStudyNode.cxx:478:28: error: ‘class vtkMRMLVolumePropertyNode’ has no member named ‘GetParentTransformNode’
&& propNode->GetParentTransformNode()
^
/tmp/LongitudinalPETCT/MRML/vtkMRMLLongitudinalPETCTStudyNode.cxx:480:23: error: ‘class vtkMRMLVolumePropertyNode’ has no member named ‘SetAndObserveTransformNodeID’
propNode->SetAndObserveTransformNodeID(
^
/tmp/LongitudinalPETCT/MRML/vtkMRMLLongitudinalPETCTStudyNode.cxx:503:23: error: ‘class vtkMRMLVolumePropertyNode’ has no member named ‘SetAndObserveTransformNodeID’
propNode->SetAndObserveTransformNodeID(NULL);
^
```
|
Thank you JC! This extension was developed as a student project, and I don't have resources to maintain it. I made this fork because the student stopped responding to pull requests. I will review and test sometime after Sunday (MICCAI). |
|
No problem and thanks for the update. In the mean time, I will most likely update the description file to build off my branch. |
|
I don't have problem merging it, and I think there is no damage, so I will just merge it to avoid further fork chain. Will also add you as collaborator. |
|
In fact, you should have already had access, since you are on the QIICR team
|
Good point. Just want to be a good citizen and check with you first 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fedorov While testing the recent updates associated with Slicer build system, I ended updating your extension
Issue #9 is fixed by 1b42eef. A entry to the migration guide has also been added. The migration guide associated with VTK6, VTK7, VTK8, Qt5 and Slicer are now all linked of https://www.slicer.org/wiki/Documentation/Nightly/Developers/Tutorials/MigrationGuide
Please, consider reviewing and testing this set of changes.
Cc: @lassoan @pieper