Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] sale_margin_delivered: Avoid rounding error #214

Closed
wants to merge 2 commits into from
Closed

[16.0][FIX] sale_margin_delivered: Avoid rounding error #214

wants to merge 2 commits into from

Commits on Jun 19, 2024

  1. [FIX] sale_margin_delivered: Uses the right field to get price reduce 

    'price_reduce' is deprecated and removed into the next version. Compute
the prirce_reduct from the price_subotal / product_uom_qty. We might
be tempted to use the 'price_reduce_taxecl' field from the sale order
line but this field is rounded by default to the monetary precision.

As an additional benefit this change ensures the compatibility with
the 'sale_triple_discount' addon. Indeed, when
'sale_triple_discount' is installed, the discount field is not used
as an aggregation of all the applied discount. It's only use to store
the first discount applied. Therefore, the field is not properly
computed since it doesn't include the second and third discount.
    @lmignon
    lmignon committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    a5ebccc View commit details
    Browse the repository at this point in the history

  2. [IMP] sale_margin_delivered: Improve UI 

    Put all the new fields after the orginal margin fields from odoo. (prior to this change, the new fields were displayed among the margin fields from Odoo
    @lmignon
    lmignon committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    6f36c4f View commit details
    Browse the repository at this point in the history