[16.0][FIX] sale_margin_delivered: Avoid rounding error #214
Conversation
|
Hi @sergio-teruel, |
|
@Shide I'll change this since |
lmignon
force-pushed
the
16.0-sale-margin-deliverd-uses-right-reduce-price-lmi
branch
from
e289eb6
to
4514ace
Compare
'price_reduce' is deprecated and removed into the next version. Compute the prirce_reduct from the price_subotal / product_uom_qty. We might be tempted to use the 'price_reduce_taxecl' field from the sale order line but this field is rounded by default to the monetary precision. As an additional benefit this change ensures the compatibility with the 'sale_triple_discount' addon. Indeed, when 'sale_triple_discount' is installed, the discount field is not used as an aggregation of all the applied discount. It's only use to store the first discount applied. Therefore, the field is not properly computed since it doesn't include the second and third discount.
lmignon
force-pushed
the
16.0-sale-margin-deliverd-uses-right-reduce-price-lmi
branch
from
4514ace
to
461a076
Compare
|
@Shide @yajo @Gelojr @fcvalgar In Odoo standard margin in % is expressed as a decimal... 1 = 100%, 0.5=50% ... In this module margin % is expressed as 100 = 1000%, 50 = 50%... what's the motivation. It's strange to store precentage value in a different way than Odoo. Can I change this and provide a migration script? |
Put all the new fields after the orginal margin fields from odoo. (prior to this change, the new fields were displayed among the margin fields from Odoo
lmignon
force-pushed
the
16.0-sale-margin-deliverd-uses-right-reduce-price-lmi
branch
from
461a076
to
6f36c4f
Compare
lmignon
changed the title
Sure! |
This would be an amazing great contribution @lmignon ! 💪🏼 😄 Thank you! |
|
Could be closed in favor of #215 |
|
included into #215 |
lmignon
deleted the
16.0-sale-margin-deliverd-uses-right-reduce-price-lmi
branch
'price_reduce' is deprecated and removed into the next version. Compute
the prirce_reduct from the price_subotal / product_uom_qty. We might
be tempted to use the 'price_reduce_taxecl' field from the sale order
line but this field is rounded by default to the monetary precision.
As an additional benefit this change ensures the compatibility with
the 'sale_triple_discount' addon. Indeed, when
'sale_triple_discount' is installed, the discount field is not used
as an aggregation of all the applied discount. It's only use to store
the first discount applied. Therefore, the field is not properly
computed since it doesn't include the second and third discount.