Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildDotNet: don't pin openssl_1_1 #214843

Merged
merged 1 commit into from
Mar 30, 2023
Merged

buildDotNet: don't pin openssl_1_1 #214843

merged 1 commit into from
Mar 30, 2023

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Feb 6, 2023

Description of changes

Was done by me in b17c551, which is a bad commit (message).

Idk why this was/is needed.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kuznero and mdarocha February 6, 2023 00:43
@raphaelr
Copy link
Contributor

raphaelr commented Feb 6, 2023

@ofborg build baget

raphaelr
raphaelr reviewed Feb 6, 2023
View reviewed changes
Copy link
Contributor

@raphaelr raphaelr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 214843 run on x86_64-linux 1

1 package blacklisted:
  • tests.writers
3 packages failed to build:
  • BeatSaberModManager
  • baget
  • python-language-server
48 packages built:
  • ArchiSteamFarm
  • alttpr-opentracker
  • azure-functions-core-tools
  • boogie (dotnetPackages.Boogie)
  • btcpayserver
  • btcpayserver-altcoins
  • commitizen
  • denaro
  • depotdownloader
  • discordchatexporter-cli
  • dotnet-aspnetcore (dotnet-aspnetcore_6 ,dotnetCorePackages.aspnetcore_6_0)
  • dotnet-aspnetcore_3 (dotnetCorePackages.aspnetcore_3_1)
  • dotnet-aspnetcore_7 (dotnetCorePackages.aspnetcore_7_0)
  • dotnet-runtime (dotnet-runtime_6 ,dotnetCorePackages.runtime_6_0)
  • dotnet-runtime_3 (dotnetCorePackages.runtime_3_1)
  • dotnet-runtime_7 (dotnetCorePackages.runtime_7_0)
  • dotnet-sdk (dotnet-sdk_6 ,dotnetCorePackages.sdk_6_0)
  • dotnet-sdk_3 (dotnetCorePackages.sdk_3_1)
  • dotnet-sdk_7 (dotnetCorePackages.sdk_7_0)
  • eventstore
  • formula
  • galaxy-buds-client
  • github-runner
  • inklecate
  • jackett
  • jellyfin
  • jetbrains.rider
  • lidarr
  • marksman
  • msbuild
  • nbxplorer
  • netcoredbg
  • nuget-to-nix
  • omnisharp-roslyn
  • opentabletdriver
  • osu-lazer
  • pinta
  • pre-commit
  • prowlarr
  • ps3-disc-dumper
  • radarr
  • roslyn
  • ryujinx
  • scarab
  • vscode-extensions.ms-vsliveshare.vsliveshare
  • wasabibackend
  • wasabiwallet
  • xivlauncher

BeatSaberModManager is already broken on master, baget and python-language-server are .NET core 3.1 packages (which is EOL upstream, but still used in nixpkgs). So I think .NET Core 3.1 requires OpenSSL 1.1, unless we can safely unpin it.

pkgs/development/compilers/dotnet/build-dotnet.nix Outdated
@@ -15,7 +15,7 @@ assert if type == "sdk" then packages != null else true;
, autoPatchelfHook
, makeWrapper
, libunwind
, openssl_1_1
, openssl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, openssl

This argument is now unused.

@mdarocha
Copy link
Contributor

Result of nixpkgs-review pr 214843 run on x86_64-linux 1

1 package blacklisted:
3 packages failed to build:
48 packages built:
BeatSaberModManager is already broken on master, baget and python-language-server are .NET core 3.1 packages (which is EOL upstream, but still used in nixpkgs). So I think .NET Core 3.1 requires OpenSSL 1.1, unless we can safely unpin it.

Yeah, I think there was some fix related to that, that's why we have it pinned. I guess this PR can be merged after #202572

Since .NET 3.1 is EOL and to be removed anyway

@mdarocha mdarocha mentioned this pull request Feb 18, 2023
Closed
@ofborg ofborg bot requested a review from mdarocha February 21, 2023 14:05
@ajs124 ajs124 marked this pull request as ready for review February 21, 2023 15:02
mdarocha
mdarocha reviewed Mar 6, 2023
View reviewed changes
Copy link
Contributor

@mdarocha mdarocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should first wait for #202572

@ajs124 ajs124 mentioned this pull request Mar 22, 2023
Merged
12 tasks
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Mar 29, 2023
@raphaelr
Copy link
Contributor

@ofborg eval

@ofborg ofborg bot requested a review from mdarocha March 29, 2023 19:22
raphaelr
raphaelr approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@raphaelr raphaelr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 214843 run on x86_64-linux 1

1 package blacklisted:
  • tests.writers
51 packages built:
  • ArchiSteamFarm
  • BeatSaberModManager
  • alttpr-opentracker
  • azure-functions-core-tools
  • boogie (dotnetPackages.Boogie)
  • btcpayserver
  • btcpayserver-altcoins
  • commitizen
  • commitizen.dist
  • denaro
  • depotdownloader
  • discordchatexporter-cli
  • dotnet-aspnetcore (dotnet-aspnetcore_6 ,dotnetCorePackages.aspnetcore_6_0)
  • dotnet-aspnetcore_7 (dotnetCorePackages.aspnetcore_7_0)
  • dotnet-aspnetcore_8 (dotnetCorePackages.aspnetcore_8_0)
  • dotnet-runtime (dotnet-runtime_6 ,dotnetCorePackages.runtime_6_0)
  • dotnet-runtime_7 (dotnetCorePackages.runtime_7_0)
  • dotnet-runtime_8 (dotnetCorePackages.runtime_8_0)
  • dotnet-sdk (dotnet-sdk_6 ,dotnetCorePackages.sdk_6_0)
  • dotnet-sdk_7 (dotnetCorePackages.sdk_7_0)
  • dotnet-sdk_8 (dotnetCorePackages.sdk_8_0)
  • eventstore
  • formula
  • galaxy-buds-client
  • github-runner
  • inklecate
  • jackett
  • jellyfin
  • jetbrains.rider
  • lidarr
  • marksman
  • msbuild
  • nbxplorer
  • netcoredbg
  • nuget-to-nix
  • omnisharp-roslyn
  • opentabletdriver
  • osu-lazer
  • pinta
  • pre-commit
  • pre-commit.dist
  • prowlarr
  • ps3-disc-dumper
  • radarr
  • readarr
  • roslyn
  • ryujinx
  • scarab
  • wasabibackend
  • wasabiwallet
  • xivlauncher

@ajs124 ajs124 merged commit 2b5e971 into NixOS:master Mar 30, 2023
@ajs124 ajs124 deleted the builddotnet-oss3 branch March 30, 2023 11:07
@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdarocha mdarocha mdarocha approved these changes

@raphaelr raphaelr raphaelr approved these changes

@kuznero kuznero Awaiting requested review from kuznero

@IvarWithoutBones IvarWithoutBones Awaiting requested review from IvarWithoutBones

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajs124 @raphaelr @mdarocha @cole-h