Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl_1_1 mark as insecure/remove before 23.05 branchoff #210452

Closed
ajs124 opened this issue Jan 12, 2023 · 26 comments · Fixed by #210463 or #232521
Closed

openssl_1_1 mark as insecure/remove before 23.05 branchoff #210452

ajs124 opened this issue Jan 12, 2023 · 26 comments · Fixed by #210463 or #232521
Labels
0.kind: bug Something is broken

Comments

@ajs124
Copy link
Member

ajs124 commented Jan 12, 2023

OpenSSL 1.1.1 (we call it openssl_1_1) will reach end of life on 11 Sep 2023.

This means we should either mark it insecure or ideally completely remove it before the 23.11 release.

The default was already switched in #150093, so most thing should use openssl_3 now.
For applications that support the OpenSSL 3 API, but need old and broken cryptography, there's also openssl_legacy, which will be supported, because it's just openssl_3 but with the legacy crypto provider enabled.

This is a tracking issue to reference and coordinate this work.

cc @NickCao

@ajs124 ajs124 added the 0.kind: bug Something is broken label Jan 12, 2023
@ajs124

This comment was marked as outdated.

@ajs124 ajs124 mentioned this issue Jan 13, 2023
13 tasks
@NickCao

This comment was marked as outdated.

@ajs124
Copy link
Member Author

ajs124 commented Jan 13, 2023

Apparently this https://github.com/loqs/PACKAGES-OSSL3 exists, which might come in handy

NickCao pushed a commit that referenced this issue Jan 13, 2023
This includes the following upstream changes:

* tvl/cl/7818: bump of all Rust dependency versions
* tvl/cl/7819: bump of version number to current revision

Prompted by #210452
@ajs124 ajs124 changed the title openssl_1_1 mark as insecure/remove openssl_1_1 mark as insecure/remove before 23.11 branchoff Jan 14, 2023
@ajs124 ajs124 reopened this Jan 14, 2023
@NickCao NickCao mentioned this issue Jan 17, 2023
12 tasks
@ajs124 ajs124 mentioned this issue Jan 22, 2023
13 tasks
@NickCao
Copy link
Member

NickCao commented Jan 25, 2023

adamcstephens pushed a commit to adamcstephens/nixpkgs that referenced this issue Jan 25, 2023
This includes the following upstream changes:

* tvl/cl/7818: bump of all Rust dependency versions
* tvl/cl/7819: bump of version number to current revision

Prompted by NixOS#210452
@ajs124 ajs124 mentioned this issue Feb 1, 2023
13 tasks
NickCao added a commit to NickCao/nixpkgs that referenced this issue Feb 4, 2023
As OpenSSL 1.1.1 will reach end of life on 11 Sep 2023.
Reference: NixOS#210452
NickCao added a commit to NickCao/nixpkgs that referenced this issue Feb 4, 2023
As OpenSSL 1.1.1 will reach end of life on 11 Sep 2023.
Reference: NixOS#210452
winterqt pushed a commit that referenced this issue Feb 4, 2023
As OpenSSL 1.1.1 will reach end of life on 11 Sep 2023.
Reference: #210452
@mdarocha
Copy link
Contributor

mdarocha commented Feb 18, 2023

Related: #214843, which is blocked by removal of .NET 3.1 (#202572)

@cyntheticfox
Copy link
Contributor

Not sure if I'm just doing this wrong, but openssl_legacy, as-written in top-level, performs an override on openssl to apply the patch. As such setting for ~/.config/nixpkgs/config.nix,

{
  packageOverrides = pkgs: rec {
    openssl = pkgs.openssl_legacy;
  };
}

fails due to infinite recursion. Should we instead have openssl_legacy as a package definition output to enable this use case, or am I approaching this in the wrong manner (should I be trying to overlay, define my own, write some kind of legacyOpenSSL option into the Nixpkgs config system)?

@ajs124
Copy link
Member Author

ajs124 commented Mar 14, 2023

This should work with an overlay, I think. Are you sure you want to enable the legacy provider for everything that you're building though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.