Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apk-tools: don't pin to openssl_1_1 #211125

Merged
merged 1 commit into from
Jan 18, 2023
Merged

apk-tools: don't pin to openssl_1_1 #211125

merged 1 commit into from
Jan 18, 2023

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jan 16, 2023

Description of changes

see #210452 for motivation

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 requested a review from alyssais January 16, 2023 18:19
@ajs124 ajs124 mentioned this pull request Jan 16, 2023
Closed
NickCao
NickCao approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by running alpine-make-vm-image, one of the two consumers of apk-tools in nixpkgs.

@alyssais alyssais merged commit c8b20e1 into NixOS:master Jan 18, 2023
@ajs124 ajs124 deleted the apk-tools-ossl3 branch January 18, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao NickCao approved these changes

@alyssais alyssais Awaiting requested review from alyssais

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajs124 @NickCao @alyssais