✨ Add an attributes() method for cleanly & safely setting block properties instead of construct #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perties instead of construct 🧑💻 Simplify required arguments for block styles 🎨 Improve method typing 🧑💻 Check for `assets` with `method_exists` to prevent unnecessary clashing 🎨 Remove unnecessary `align_content` conditional
🎨 Improve default typing on the `assets` method 🎨 Simplify the default `styles` property
…rties 🎨 Move example data into the `example()` method 🎨 Add types to methods where applicable 🎨 Simplify the default `styles` configuration 🎨 Improve default typing on the `assets` method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log
Enhancements
attributes()method for cleanly & safely setting block properties instead of constructassetswithmethod_existsto prevent unnecessary clashingalign_contentconditionalassetsmethod (Fixes Native type hinting #206)stylespropertyexample()method in the block construct stub