🎨 add type hints to assets method
#208
Conversation
codepuncher
force-pushed
the
gh/issue/206
branch
from
700a8b2
to
a25e5a5
Compare
| 'public function enqueue($block)' => 'public function assets($block)', | ||
| 'public function enqueue($block = [])' => 'public function assets($block)', | ||
| 'public function enqueue()' => 'public function assets($block)', | ||
| 'public function assets($block)' => 'public function assets(array $block)', |
There was a problem hiding this comment.
sadly this wont work since PHP will throw an error when ACF Composer gets booted in CLI because the classes don't match the parent
There was a problem hiding this comment.
I see. How would you like to handle this then?
Add manual update notes like you did for the v3 release?
sed -i 's/public function assets($block)/public function assets(array $block)/g' app/Blocks/*.php?
There was a problem hiding this comment.
I see. How would you like to handle this then? Add manual update notes like you did for the v3 release?
sed -i 's/public function assets($block)/public function assets(array $block)/g' app/Blocks/*.php?
yeah sadly it would be another breaking change which i really didn't want to do. i actually intentionally renamed this from enqueue to assets just to avoid it - but its my bad for not adding the types. :/
i would probably just put it in the upgrade v3 upgrade guide and hope that there has been a lot of upgrades if i were to do this i guess.
There was a problem hiding this comment.
I also noticed that I missed off the :void return type from these upgrades anyway so the end result would be a fatal error.
There was a problem hiding this comment.
pondering maybe removing assets() from the abstract class and doing a method_exists check or something instead. not sure, just a thought.
There was a problem hiding this comment.
Well, I guess method_exists makes some sense; not all blocks have assets to enqueue so the user would only add assets() when they need it.
There was a problem hiding this comment.
the other upgrades from enqueue() are still missing :void
codepuncher
force-pushed
the
gh/issue/206
branch
from
291c893
to
9beee88
Compare
|
With this needing a bit more work and me not having permission to make changes to your branch, I'm going to replace this PR with #210 |
Fixes #206