Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KHR_parallel_shader_compile: lost context behavior spec & test #3188

Merged
merged 1 commit into from
Nov 25, 2020
Merged

KHR_parallel_shader_compile: lost context behavior spec & test #3188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions extensions/KHR_parallel_shader_compile/extension.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
availability (<code>COMPLETION_STATUS_KHR</code>) can be queried without potentially incurring
stalls.
</feature>

<feature>
When the context is lost, completion status queries must return true unconditionally. This is
intended to prevent applications from entering an infinite status polling loop.
</feature>
</features>

<p>Notes: <ul style="list-style-type: circle">
Expand Down Expand Up @@ -142,5 +147,8 @@
<revision date="2019/05/10">
<change>Moved to community approved.</change>
</revision>
<revision date="2020/11/24">
<change>Specify lost context behavior.</change>
</revision>
</history>
</extension>
1 change: 1 addition & 0 deletions sdk/tests/conformance/extensions/00_test_list.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
--min-version 1.0.3 --max-version 1.9.9 ext-sRGB.html
--min-version 1.0.2 ext-texture-filter-anisotropic.html
--min-version 1.0.2 get-extension.html
--min-version 1.0.4 khr-parallel-shader-compile.html
--max-version 1.9.9 oes-standard-derivatives.html
--max-version 1.9.9 oes-texture-float-with-canvas.html
--max-version 1.9.9 oes-texture-float-with-image-data.html
Expand Down
93 changes: 93 additions & 0 deletions sdk/tests/conformance/extensions/khr-parallel-shader-compile.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
<!--
Copyright (c) 2020 The Khronos Group Inc.
Use of this source code is governed by an MIT-style license that can be
found in the LICENSE.txt file.
-->

<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<link rel="stylesheet" href="../../resources/js-test-style.css"/>
<script src="../../js/js-test-pre.js"></script>
<script src="../../js/webgl-test-utils.js"></script>
</head>
<body>
<div id="description"></div>
<div id="console"></div>

<script>
"use strict";
description("Test KHR_parallel_shader_compile");

const wtu = WebGLTestUtils;

const gl = wtu.create3DContext();
const loseContext = wtu.getExtensionWithKnownPrefixes(gl, "WEBGL_lose_context");

let counter = 0;
const vertexSource = () => `
void main() {
gl_Position = vec4(${counter++}, 1, 1, 1);
}`;
const fragmentSource = () => `
void main() {
gl_FragColor = vec4(0.${counter++}, 1, 1, 1);
}`;

const vs = gl.createShader(gl.VERTEX_SHADER);
const fs = gl.createShader(gl.FRAGMENT_SHADER);
const program = gl.createProgram();
gl.attachShader(program, vs);
gl.attachShader(program, fs);

const COMPLETION_STATUS_KHR = 0x91B1;

gl.shaderSource(vs, vertexSource());
gl.compileShader(vs);
let status = gl.getShaderParameter(vs, COMPLETION_STATUS_KHR);
if (status !== null) testFailed('Extension disabled, status should be null');
wtu.glErrorShouldBe(gl, gl.INVALID_ENUM, "extension disabled");

gl.shaderSource(fs, fragmentSource());
gl.compileShader(fs);

gl.linkProgram(program);
status = gl.getProgramParameter(program, COMPLETION_STATUS_KHR);
if (status !== null) testFailed('Extension disabled, status should be null');
wtu.glErrorShouldBe(gl, gl.INVALID_ENUM, "extension disabled");

const ext = wtu.getExtensionWithKnownPrefixes(gl, "KHR_parallel_shader_compile");
if (!ext) {
testPassed("No KHR_parallel_shader_compile support -- this is legal");
} else {
testPassed("Successfully enabled KHR_parallel_shader_compile extension");

shouldBe("ext.COMPLETION_STATUS_KHR", "0x91B1");

debug("Checking that status is a boolean.");
gl.shaderSource(vs, vertexSource());
gl.compileShader(vs);
let status = gl.getShaderParameter(vs, COMPLETION_STATUS_KHR);
if (status !== true && status !== false) testFailed("status should be a boolean");

gl.linkProgram(program);
status = gl.getProgramParameter(program, COMPLETION_STATUS_KHR);
if (status !== true && status !== false) testFailed("status should be a boolean");

debug("Checking that status is true when context is lost.");
if (loseContext) {
loseContext.loseContext();
status = gl.getShaderParameter(vs, COMPLETION_STATUS_KHR);
if (status !== true) testFailed("status should be true when context is lost");
status = gl.getProgramParameter(program, COMPLETION_STATUS_KHR);
if (status !== true) testFailed("status should be true when context is lost");
}
}

const successfullyParsed = true;
</script>

<script src="../../js/js-test-post.js"></script>
</body>
</html>