Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KHR_parallel_shader_compile: lost context behavior spec & test #3188

Merged
merged 1 commit into from
Nov 25, 2020
Merged

KHR_parallel_shader_compile: lost context behavior spec & test #3188

merged 1 commit into from
Nov 25, 2020

Conversation

jdarpinian
Copy link
Contributor

This was proposed on the public WebGL mailing list, where it was pointed out that KHR_robustness seems to imply that this should be the behavior of all queries. https://www.khronos.org/webgl/public-mailing-list/public_webgl/1904/msg00004.php. The OpenGL working group agrees: KhronosGroup/OpenGL-Registry#263

kenrussell
kenrussell approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@kenrussell kenrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test. I wish it were possible to make assertions that the completion status of programs that take a long time to compile was false and then transitions to true - let's try to strengthen the test in the future.

@kenrussell kenrussell merged commit 6308f19 into KhronosGroup:master Nov 25, 2020
blueboxd pushed a commit to blueboxd/chromium-legacy that referenced this pull request Nov 26, 2020
@jdarpinian
COMPLETION_STATUS_KHR should be true on context loss
c67854d 
KHR_parallel_shader_compile COMPLETION_STATUS_KHR queries should return
true unconditionally when the context is lost. This is intended to
prevent applications from entering an infinite polling loop.

Spec clarification and test are landing upstream:
KhronosGroup/WebGL#3188

Bug: angleproject:3379
Change-Id: I3c63235ccc3e07e0557e80021888886f893d268a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559534
Auto-Submit: James Darpinian <[email protected]>
Commit-Queue: Kenneth Russell <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#831184}
mkarolin added a commit to brave/brave-core that referenced this pull request Dec 16, 2020
@mkarolin
webgl_rendering_context_base patch change.
d85fdcc 
Shifted a couple of patches.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/c67854d8f41a3b02257e2acb2fb7480f609abd11

commit c67854d8f41a3b02257e2acb2fb7480f609abd11
Author: James Darpinian <[email protected]>
Date:   Thu Nov 26 00:22:24 2020 +0000

    COMPLETION_STATUS_KHR should be true on context loss

    KHR_parallel_shader_compile COMPLETION_STATUS_KHR queries should return
    true unconditionally when the context is lost. This is intended to
    prevent applications from entering an infinite polling loop.

    Spec clarification and test are landing upstream:
    KhronosGroup/WebGL#3188

    Bug: angleproject:3379
mkarolin added a commit to brave/brave-core that referenced this pull request Dec 18, 2020
@mkarolin
webgl_rendering_context_base patch change.
5f678f1 
Shifted a couple of patches.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/c67854d8f41a3b02257e2acb2fb7480f609abd11

commit c67854d8f41a3b02257e2acb2fb7480f609abd11
Author: James Darpinian <[email protected]>
Date:   Thu Nov 26 00:22:24 2020 +0000

    COMPLETION_STATUS_KHR should be true on context loss

    KHR_parallel_shader_compile COMPLETION_STATUS_KHR queries should return
    true unconditionally when the context is lost. This is intended to
    prevent applications from entering an infinite polling loop.

    Spec clarification and test are landing upstream:
    KhronosGroup/WebGL#3188

    Bug: angleproject:3379
mkarolin added a commit to brave/brave-core that referenced this pull request Dec 23, 2020
@mkarolin
webgl_rendering_context_base patch change.
aea118b 
Shifted a couple of patches.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/c67854d8f41a3b02257e2acb2fb7480f609abd11

commit c67854d8f41a3b02257e2acb2fb7480f609abd11
Author: James Darpinian <[email protected]>
Date:   Thu Nov 26 00:22:24 2020 +0000

    COMPLETION_STATUS_KHR should be true on context loss

    KHR_parallel_shader_compile COMPLETION_STATUS_KHR queries should return
    true unconditionally when the context is lost. This is intended to
    prevent applications from entering an infinite polling loop.

    Spec clarification and test are landing upstream:
    KhronosGroup/WebGL#3188

    Bug: angleproject:3379
mariospr pushed a commit to brave/brave-core that referenced this pull request Jan 12, 2021
@mkarolin @mariospr
webgl_rendering_context_base patch change.
98cf3cf 
Shifted a couple of patches.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/c67854d8f41a3b02257e2acb2fb7480f609abd11

commit c67854d8f41a3b02257e2acb2fb7480f609abd11
Author: James Darpinian <[email protected]>
Date:   Thu Nov 26 00:22:24 2020 +0000

    COMPLETION_STATUS_KHR should be true on context loss

    KHR_parallel_shader_compile COMPLETION_STATUS_KHR queries should return
    true unconditionally when the context is lost. This is intended to
    prevent applications from entering an infinite polling loop.

    Spec clarification and test are landing upstream:
    KhronosGroup/WebGL#3188

    Bug: angleproject:3379
mkarolin added a commit to brave/brave-core that referenced this pull request Jan 14, 2021
@mkarolin
webgl_rendering_context_base patch change.
c0dcd72 
Shifted a couple of patches.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/c67854d8f41a3b02257e2acb2fb7480f609abd11

commit c67854d8f41a3b02257e2acb2fb7480f609abd11
Author: James Darpinian <[email protected]>
Date:   Thu Nov 26 00:22:24 2020 +0000

    COMPLETION_STATUS_KHR should be true on context loss

    KHR_parallel_shader_compile COMPLETION_STATUS_KHR queries should return
    true unconditionally when the context is lost. This is intended to
    prevent applications from entering an infinite polling loop.

    Spec clarification and test are landing upstream:
    KhronosGroup/WebGL#3188

    Bug: angleproject:3379
mariospr pushed a commit to brave/brave-core that referenced this pull request Jan 19, 2021
@mkarolin @mariospr
webgl_rendering_context_base patch change.
bae14fb 
Shifted a couple of patches.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/c67854d8f41a3b02257e2acb2fb7480f609abd11

commit c67854d8f41a3b02257e2acb2fb7480f609abd11
Author: James Darpinian <[email protected]>
Date:   Thu Nov 26 00:22:24 2020 +0000

    COMPLETION_STATUS_KHR should be true on context loss

    KHR_parallel_shader_compile COMPLETION_STATUS_KHR queries should return
    true unconditionally when the context is lost. This is intended to
    prevent applications from entering an infinite polling loop.

    Spec clarification and test are landing upstream:
    KhronosGroup/WebGL#3188

    Bug: angleproject:3379
mkarolin added a commit to brave/brave-core that referenced this pull request Jan 21, 2021
@mkarolin
webgl_rendering_context_base patch change.
4006e25 
Shifted a couple of patches.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/c67854d8f41a3b02257e2acb2fb7480f609abd11

commit c67854d8f41a3b02257e2acb2fb7480f609abd11
Author: James Darpinian <[email protected]>
Date:   Thu Nov 26 00:22:24 2020 +0000

    COMPLETION_STATUS_KHR should be true on context loss

    KHR_parallel_shader_compile COMPLETION_STATUS_KHR queries should return
    true unconditionally when the context is lost. This is intended to
    prevent applications from entering an infinite polling loop.

    Spec clarification and test are landing upstream:
    KhronosGroup/WebGL#3188

    Bug: angleproject:3379
mariospr pushed a commit to brave/brave-core that referenced this pull request Jan 25, 2021
@mkarolin @mariospr
webgl_rendering_context_base patch change.
7168fc8 
Shifted a couple of patches.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/c67854d8f41a3b02257e2acb2fb7480f609abd11

commit c67854d8f41a3b02257e2acb2fb7480f609abd11
Author: James Darpinian <[email protected]>
Date:   Thu Nov 26 00:22:24 2020 +0000

    COMPLETION_STATUS_KHR should be true on context loss

    KHR_parallel_shader_compile COMPLETION_STATUS_KHR queries should return
    true unconditionally when the context is lost. This is intended to
    prevent applications from entering an infinite polling loop.

    Spec clarification and test are landing upstream:
    KhronosGroup/WebGL#3188

    Bug: angleproject:3379
mkarolin added a commit to brave/brave-core that referenced this pull request Jan 26, 2021
@mkarolin
webgl_rendering_context_base patch change.
50351fa 
Shifted a couple of patches.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/c67854d8f41a3b02257e2acb2fb7480f609abd11

commit c67854d8f41a3b02257e2acb2fb7480f609abd11
Author: James Darpinian <[email protected]>
Date:   Thu Nov 26 00:22:24 2020 +0000

    COMPLETION_STATUS_KHR should be true on context loss

    KHR_parallel_shader_compile COMPLETION_STATUS_KHR queries should return
    true unconditionally when the context is lost. This is intended to
    prevent applications from entering an infinite polling loop.

    Spec clarification and test are landing upstream:
    KhronosGroup/WebGL#3188

    Bug: angleproject:3379
mkarolin added a commit to brave/brave-core that referenced this pull request Jan 27, 2021
@mkarolin
webgl_rendering_context_base patch change.
5b29a42 
Shifted a couple of patches.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/c67854d8f41a3b02257e2acb2fb7480f609abd11

commit c67854d8f41a3b02257e2acb2fb7480f609abd11
Author: James Darpinian <[email protected]>
Date:   Thu Nov 26 00:22:24 2020 +0000

    COMPLETION_STATUS_KHR should be true on context loss

    KHR_parallel_shader_compile COMPLETION_STATUS_KHR queries should return
    true unconditionally when the context is lost. This is intended to
    prevent applications from entering an infinite polling loop.

    Spec clarification and test are landing upstream:
    KhronosGroup/WebGL#3188

    Bug: angleproject:3379
mkarolin added a commit to brave/brave-core that referenced this pull request Jan 27, 2021
@mkarolin
webgl_rendering_context_base patch change.
91da5f2 
Shifted a couple of patches.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/c67854d8f41a3b02257e2acb2fb7480f609abd11

commit c67854d8f41a3b02257e2acb2fb7480f609abd11
Author: James Darpinian <[email protected]>
Date:   Thu Nov 26 00:22:24 2020 +0000

    COMPLETION_STATUS_KHR should be true on context loss

    KHR_parallel_shader_compile COMPLETION_STATUS_KHR queries should return
    true unconditionally when the context is lost. This is intended to
    prevent applications from entering an infinite polling loop.

    Spec clarification and test are landing upstream:
    KhronosGroup/WebGL#3188

    Bug: angleproject:3379
mkarolin added a commit to brave/brave-core that referenced this pull request Feb 3, 2021
@mkarolin
webgl_rendering_context_base patch change.
87ca245 
Shifted a couple of patches.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/c67854d8f41a3b02257e2acb2fb7480f609abd11

commit c67854d8f41a3b02257e2acb2fb7480f609abd11
Author: James Darpinian <[email protected]>
Date:   Thu Nov 26 00:22:24 2020 +0000

    COMPLETION_STATUS_KHR should be true on context loss

    KHR_parallel_shader_compile COMPLETION_STATUS_KHR queries should return
    true unconditionally when the context is lost. This is intended to
    prevent applications from entering an infinite polling loop.

    Spec clarification and test are landing upstream:
    KhronosGroup/WebGL#3188

    Bug: angleproject:3379
mkarolin added a commit to brave/brave-core that referenced this pull request Feb 4, 2021
@mkarolin
webgl_rendering_context_base patch change.
0af4eef 
Shifted a couple of patches.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/c67854d8f41a3b02257e2acb2fb7480f609abd11

commit c67854d8f41a3b02257e2acb2fb7480f609abd11
Author: James Darpinian <[email protected]>
Date:   Thu Nov 26 00:22:24 2020 +0000

    COMPLETION_STATUS_KHR should be true on context loss

    KHR_parallel_shader_compile COMPLETION_STATUS_KHR queries should return
    true unconditionally when the context is lost. This is intended to
    prevent applications from entering an infinite polling loop.

    Spec clarification and test are landing upstream:
    KhronosGroup/WebGL#3188

    Bug: angleproject:3379
mkarolin added a commit to brave/brave-core that referenced this pull request Feb 5, 2021
@mkarolin
webgl_rendering_context_base patch change.
0b1a797 
Shifted a couple of patches.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/c67854d8f41a3b02257e2acb2fb7480f609abd11

commit c67854d8f41a3b02257e2acb2fb7480f609abd11
Author: James Darpinian <[email protected]>
Date:   Thu Nov 26 00:22:24 2020 +0000

    COMPLETION_STATUS_KHR should be true on context loss

    KHR_parallel_shader_compile COMPLETION_STATUS_KHR queries should return
    true unconditionally when the context is lost. This is intended to
    prevent applications from entering an infinite polling loop.

    Spec clarification and test are landing upstream:
    KhronosGroup/WebGL#3188

    Bug: angleproject:3379
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
@jdarpinian @copybara-github
COMPLETION_STATUS_KHR should be true on context loss
3a7dcb7 
KHR_parallel_shader_compile COMPLETION_STATUS_KHR queries should return
true unconditionally when the context is lost. This is intended to
prevent applications from entering an infinite polling loop.

Spec clarification and test are landing upstream:
KhronosGroup/WebGL#3188

Bug: angleproject:3379
Change-Id: I3c63235ccc3e07e0557e80021888886f893d268a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559534
Auto-Submit: James Darpinian <[email protected]>
Commit-Queue: Kenneth Russell <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#831184}
GitOrigin-RevId: c67854d8f41a3b02257e2acb2fb7480f609abd11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenrussell kenrussell kenrussell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdarpinian @kenrussell