Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Guest User Permission with Public Content Access #2183

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Create Guest User Permission with Public Content Access #2183

merged 3 commits into from
Aug 7, 2024

Conversation

Rup-Narayan-Rajbanshi
Copy link
Collaborator

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi commented Jun 25, 2024 •
edited
Loading

Addresses

Changes

  • Restrict guest user to do post operation for specified apis.

Checklist

Things that should succeed before merging.

  • Updated/ran unit tests
  • Updated CHANGELOG.md

susilnem
susilnem reviewed Jun 26, 2024
View reviewed changes
api/serializers.py Outdated Show resolved Hide resolved
susilnem
susilnem requested changes Jun 26, 2024
View reviewed changes
Copy link
Member

@susilnem susilnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some changes

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/user-guest-permission branch 2 times, most recently from 2df90cc to f7d6e8b Compare June 26, 2024 06:08
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as ready for review June 26, 2024 06:10
thenav56
thenav56 requested changes Jun 27, 2024
View reviewed changes
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

api/migrations/0211_profile_limit_access_to_guest.py Outdated Show resolved Hide resolved
api/models.py Outdated Show resolved Hide resolved
api/drf_views.py Show resolved Hide resolved
@thenav56 thenav56 marked this pull request as draft June 27, 2024 03:51
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as ready for review July 1, 2024 10:24
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi changed the title Add denie guest user permission in post apis. Add guest user permission in post apis. Jul 3, 2024
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as draft July 3, 2024 05:11
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/user-guest-permission branch 2 times, most recently from 692ee14 to a6ad41d Compare July 3, 2024 10:43
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as ready for review July 3, 2024 10:43
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/user-guest-permission branch 2 times, most recently from 54bcc09 to 9320690 Compare July 9, 2024 04:45
@samshara samshara mentioned this pull request Jul 9, 2024
Merged
6 tasks
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/user-guest-permission branch 2 times, most recently from 831eb0e to 3743bf3 Compare July 10, 2024 09:18
thenav56
thenav56 requested changes Jul 10, 2024
View reviewed changes
api/models.py Outdated Show resolved Hide resolved
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/user-guest-permission branch 6 times, most recently from ecba7b0 to 6e008af Compare July 12, 2024 06:51
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/user-guest-permission branch 2 times, most recently from f47d444 to ce60c94 Compare July 17, 2024 09:07
@szabozoltan69 szabozoltan69 force-pushed the develop branch 3 times, most recently from 1f3ac08 to 7567cf5 Compare July 17, 2024 10:45
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/user-guest-permission branch 2 times, most recently from 383e133 to afc2a10 Compare July 18, 2024 11:33
thenav56
thenav56 requested changes Jul 30, 2024
View reviewed changes
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes

api/test_views.py Outdated Show resolved Hide resolved
api/drf_views.py Show resolved Hide resolved
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/user-guest-permission branch 3 times, most recently from 47a39f1 to 057423d Compare July 30, 2024 11:18
thenav56
thenav56 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to do QA for new changes as well :D

@samshara samshara changed the title Add guest user permission in post apis. Create Guest User Permission with Public Content Access Aug 7, 2024
@samshara samshara self-assigned this Aug 7, 2024
@samshara samshara merged commit ff82180 into develop Aug 7, 2024
2 checks passed
@samshara samshara deleted the feature/user-guest-permission branch August 7, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susilnem susilnem susilnem approved these changes

@thenav56 thenav56 thenav56 approved these changes

Assignees

@samshara samshara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rup-Narayan-Rajbanshi @thenav56 @susilnem @samshara