Add guest permission in GET apis.

api/drf_views.py

@@ -1309,7 +1309,7 @@ class UsersViewset(viewsets.ReadOnlyModelViewSet):
     """
 
     serializer_class = UserSerializer
-    permission_classes = [IsAuthenticated]
+    permission_classes = [IsAuthenticated, DenyGuestUserMutationPermission]
     filterset_class = UserFilterSet
 
     def get_queryset(self):

api/migrations/0211_profile_limit_access_to_guest.py → api/migrations/0212_profile_limit_access_to_guest.py

@@ -1,12 +1,12 @@
-# Generated by Django 4.2.13 on 2024-07-12 06:47
+# Generated by Django 4.2.13 on 2024-07-17 08:42
 
 from django.db import migrations, models
 
 
 class Migration(migrations.Migration):
 
     dependencies = [
-        ("api", "0210_profile_accepted_montandon_license_terms"),
+        ("api", "0211_alter_countrydirectory_unique_together_and_more"),
     ]
 
     operations = [

api/test_views.py

@@ -36,19 +36,19 @@ def test_guest_user_permission(self):
             "/api/v2/del_subscription/",
             "/api/v2/external-token/",
         ]
-
+        id = 1
         go_apis = [
             "/api/v2/dref/",
             "/api/v2/dref-final-report/",
-            "/api/v2/dref-final-report/{id}/publish/",
+            f"/api/v2/dref-final-report/{id}/publish/",
             "/api/v2/dref-op-update/",
-            "/api/v2/dref-op-update/{id}/publish/",
+            f"/api/v2/dref-op-update/{id}/publish/",
             "/api/v2/dref-share/",
-            "/api/v2/dref/{id}/publish/",
+            f"/api/v2/dref/{id}/publish/",
             "/api/v2/flash-update/",
             "/api/v2/flash-update-file/multiple/",
             "/api/v2/local-units/",
-            "/api/v2/local-units/{id}/validate/",
+            f"/api/v2/local-units/{id}/validate/",
             "/api/v2/pdf-export/",
             "/api/v2/per-assessment/",
             "/api/v2/per-document-upload/",
@@ -67,30 +67,109 @@ def test_guest_user_permission(self):
             "/api/v2/subscription/",
             "/api/v2/user/",
         ]
+        country__iso__iexact = "NPL"
+
+        get_apis = [
+            "/api/v2/active-dref/",
+            f"/api/v2/active-dref/{id}/",
+            "/api/v2/aggregated-per-process-status/",
+            f"/api/v2/aggregated-per-process-status/{id}/",
+            "/api/v2/completed-dref/",
+            f"/api/v2/data-bank/country-overview/{country__iso__iexact}/",
+            "/api/v2/dref/",
+            "/api/v2/dref-files/",
+            "/api/v2/dref-final-report/",
+            f"/api/v2/dref-final-report/{id}/",
+            "/api/v2/dref-op-update/",
+            "/api/v2/dref-share-user/",
+            f"/api/v2/dref-share-user/{id}/",
+            f"/api/v2/dref/{id}/",
+            "/api/v2/field-report/",
+            f"/api/v2/field-report/{id}/",
+            "/api/v2/flash-update/",
+            "/api/v2/flash-update-file/",
+            f"/api/v2/flash-update/{id}/",
+            "/api/v2/language/",
+            f"/api/v2/language/{id}/",
+            "/api/v2/local-units/",
+            f"/api/v2/local-units/{id}/",
+            "/api/v2/ops-learning/",
+            f"/api/v2/ops-learning/{id}/",
+            f"/api/v2/pdf-export/{id}/",
+            "/api/v2/per-assessment/",
+            f"/api/v2/per-assessment/{id}/",
+            "/api/v2/per-document-upload/",
+            f"/api/v2/per-document-upload/{id}/",
+            "/api/v2/per-file/",
+            "/api/v2/per-options/",
+            "/api/v2/per-overview/",
+            f"/api/v2/per-overview/{id}/",
+            "/api/v2/per-prioritization/",
+            f"/api/v2/per-prioritization/{id}/",
+            "/api/v2/per-process-status/",
+            f"/api/v2/per-process-status/{id}/",
+            "/api/v2/per-stats/",
+            "/api/v2/per-work-plan/",
+            f"/api/v2/per-work-plan/{id}/",
+            "/api/v2/perdocs/",
+            f"/api/v2/perdocs/{id}/",
+            "/api/v2/personnel_deployment/",
+            f"/api/v2/personnel_deployment/{id}/",
+            "/api/v2/profile/",
+            f"/api/v2/profile/{id}/",
+            f"/api/v2/share-flash-update/{id}/",
+            "/api/v2/subscription/",
+            f"/api/v2/subscription/{id}/",
+            "/api/v2/user/",
+            f"/api/v2/user/{id}/",
+            "/api/v2/user/me/",
+            "/api/v2/users/",
+            f"/api/v2/users/{id}/",
+        ]
+        # TODO Add test case for export apis
+        # get_export_apis = [
+        #     f"/api/v2/export-flash-update/{1}/",
+        #     f"/api/v2/export-per/{1}/",
+        # ]
 
         go_apis_req_additional_perm = [
             "/api/v2/ops-learning/",
             "/api/v2/per-overview/",
-            "/api/v2/user/{id}/accepted_license_terms/",
-            "/api/v2/language/{id}/bulk-action/",
+            f"/api/v2/user/{id}/accepted_license_terms/",
+            f"/api/v2/language/{id}/bulk-action/",
         ]
 
         self.authenticate(user=self.guest_user)
+
+        # Guest user should not be able to access get apis that requires IsAuthenticated permission
+        for api_url in get_apis:
+            response = self.client.get(api_url).json()
+            error_code = response.get("error_code")
+            self.assertIn(error_code, [403, 401])
+
+        # Guest user should not be able to hit post apis.
         for api_url in go_apis + go_apis_req_additional_perm:
             response = self.client.post(api_url, json=body).json()
             self.assertIn(response["error_code"], [401, 403])
 
+        # Guest user should be able to access guest apis
         for api_url in guest_apis:
             response = self.client.post(api_url, json=body).json()
             error_code = response.get("error_code", None)
             self.assertNotIn(error_code, [403, 401])
 
+        # Go user should be able to access go_apis
         self.authenticate(user=self.go_user)
         for api_url in go_apis:
             response = self.client.post(api_url, json=body).json()
             error_code = response.get("error_code", None)
             self.assertNotIn(error_code, [403, 401])
 
+        for api_url in get_apis:
+            response = self.client.get(api_url).json()
+            error_code = response.get("error_code", None)
+            self.assertNotIn(error_code, [403, 401])
+
 
 class AuthTokenTest(APITestCase):
     def setUp(self):

databank/views.py

@@ -2,6 +2,8 @@
 from rest_framework.authentication import BasicAuthentication, TokenAuthentication
 from rest_framework.permissions import IsAuthenticated
 
+from main.permissions import DenyGuestUserMutationPermission
+
 from .filter_set import FDRSIncomeFilter
 from .models import CountryOverview, FDRSIncome
 from .serializers import CountryOverviewSerializer, FDRSIncomeSerializer
@@ -11,7 +13,7 @@ class CountryOverviewViewSet(mixins.RetrieveModelMixin, viewsets.GenericViewSet)
     queryset = CountryOverview.objects.all()
     # TODO: Use global authentication class
     authentication_classes = (BasicAuthentication, TokenAuthentication)
-    permission_classes = (IsAuthenticated,)
+    permission_classes = (IsAuthenticated, DenyGuestUserMutationPermission)
     serializer_class = CountryOverviewSerializer
     lookup_field = "country__iso__iexact"
 

deployments/drf_views.py

@@ -143,7 +143,7 @@ class Meta:
 
 class PersonnelDeploymentViewset(viewsets.ReadOnlyModelViewSet):
     authentication_classes = (TokenAuthentication,)
-    permission_classes = (IsAuthenticated,)
+    permission_classes = (IsAuthenticated, DenyGuestUserMutationPermission)
     queryset = PersonnelDeployment.objects.all()
     serializer_class = PersonnelDeploymentSerializer
     filterset_class = PersonnelDeploymentFilter

dref/views.py

@@ -200,7 +200,7 @@ def multiple_file(self, request, pk=None, version=None):
 
 class CompletedDrefOperationsViewSet(viewsets.ReadOnlyModelViewSet):
     serializer_class = CompletedDrefOperationsSerializer
-    permission_classes = [permissions.IsAuthenticated]
+    permission_classes = [permissions.IsAuthenticated, DenyGuestUserMutationPermission]
     filterset_class = CompletedDrefOperationsFilterSet
     queryset = DrefFinalReport.objects.filter(is_published=True).order_by("-created_at").distinct()
 
@@ -211,7 +211,7 @@ def get_queryset(self):
 
 class ActiveDrefOperationsViewSet(viewsets.ReadOnlyModelViewSet):
     serializer_class = MiniDrefSerializer
-    permission_classes = [permissions.IsAuthenticated]
+    permission_classes = [permissions.IsAuthenticated, DenyGuestUserMutationPermission]
     filterset_class = ActiveDrefFilterSet
     queryset = (
         Dref.objects.prefetch_related("planned_interventions", "needs_identified", "national_society_actions", "users")
@@ -239,7 +239,7 @@ def post(self, request):
 
 
 class DrefShareUserViewSet(viewsets.ReadOnlyModelViewSet):
-    permissions_classes = [permissions.IsAuthenticated]
+    permission_classes = [permissions.IsAuthenticated, DenyGuestUserMutationPermission]
     serializer_class = DrefShareUserSerializer
     filterset_class = DrefShareUserFilterSet
 

flash_update/test_views.py

@@ -2,7 +2,6 @@
 from unittest import mock
 
 from django.conf import settings
-from django.contrib.auth.models import User
 
 import api.models as models
 from deployments.factories.user import UserFactory
@@ -22,7 +21,7 @@
 class FlashUpdateTest(APITestCase):
 
     def setUp(self):
-        self.user = User.objects.create(username="jo")
+        self.user = UserFactory.create(username="jo")
         self.country1 = models.Country.objects.create(name="abc")
         self.country2 = models.Country.objects.create(name="xyz")
         self.district1 = models.District.objects.create(name="test district1", country=self.country1)
@@ -142,7 +141,7 @@ def test_patch(self):
         self.assertEqual(flash_id.share_with, FlashUpdate.FlashShareWith.IFRC_SECRETARIAT)
 
     def test_get_flash_update(self):
-        user1 = User.objects.create(username="abc")
+        user1 = UserFactory.create(username="abc")
         flash_update1, flash_update2, flash_update3 = FlashUpdateFactory.create_batch(3, created_by=user1)
         self.client.force_authenticate(user=user1)
         response1 = self.client.get("/api/v2/flash-update/").json()
@@ -158,7 +157,7 @@ def test_get_flash_update(self):
         self.assertEqual(response["id"], flash_update1.id)
 
         #  try with another user
-        user2 = User.objects.create(username="xyz")
+        user2 = UserFactory.create(username="xyz")
         self.client.force_authenticate(user=user2)
         flash_update4, flash_update5 = FlashUpdateFactory.create_batch(2, created_by=user2)
         response2 = self.client.get("/api/v2/flash-update/").json()
@@ -168,13 +167,13 @@ def test_get_flash_update(self):
         self.assertNotIn([data["id"] for data in response2["results"]], [data["id"] for data in response1["results"]])
 
         # try with users who has no any flash update created
-        user3 = User.objects.create(username="ram")
+        user3 = UserFactory.create(username="ram")
         self.client.force_authenticate(user=user3)
         response3 = self.client.get("/api/v2/flash-update/").json()
         self.assertEqual(response3["count"], 5)
 
     def test_filter(self):
-        user = User.objects.create(username="xyz")
+        user = UserFactory.create(username="xyz")
         self.client.force_authenticate(user=user)
         hazard_type1 = models.DisasterType.objects.create(name="disaster_type1")
         hazard_type2 = models.DisasterType.objects.create(name="disaster_type2")

flash_update/views.py

@@ -117,7 +117,9 @@ class ShareFlashUpdateViewSet(mixins.CreateModelMixin, mixins.RetrieveModelMixin
 
 
 class ExportFlashUpdateView(views.APIView):
-    permission_classes = [permissions.IsAuthenticated]
+    permission_classes = [
+        permissions.IsAuthenticated,
+    ]
 
     @extend_schema(request=None, responses=ExportFlashUpdateViewSerializer)
     def get(self, request, pk, format=None):

lang/tests.py

@@ -2,7 +2,7 @@
 from unittest import mock
 
 from django.conf import settings
-from django.contrib.auth.models import Permission, User
+from django.contrib.auth.models import Permission
 from django.core import management
 from django.test import override_settings
 
@@ -131,7 +131,7 @@ def test_bulk_action(self):
         self.assertEqual(first_string_key, string_1["key"])
 
     def test_user_me(self):
-        user = User.objects.create_user(
+        user = UserFactory.create(
             username="[email protected]",
             first_name="User",
             last_name="Toot",

main/permissions.py

@@ -14,17 +14,12 @@ def has_object_permission(self, request, view, obj):
 
 class DenyGuestUserMutationPermission(permissions.BasePermission):
     """
-    Custom permission to deny mutation actions for logged-in guest users.
+    Custom permission to deny mutation and query actions for logged-in guest users.
 
-    This permission class allows all safe (read-only) operations but restricts
-    any mutation (write, update, delete) operations if the user is a guest.
+    This permission class restricts all (read, write, update, delete) operations if the user is a guest.
     """
 
     def _has_permission(self, request, view):
-        # Allow all safe methods (GET, HEAD, OPTIONS) which are non-mutating.
-        if request.method in permissions.SAFE_METHODS:
-            return True
-
         # For mutation methods (POST, PUT, DELETE, etc.):
         # Check if the user is authenticated.
         if not bool(request.user and request.user.is_authenticated):

per/drf_views.py

@@ -106,7 +106,7 @@ class PERDocsViewset(viewsets.ReadOnlyModelViewSet):
     # Duplicate of FormDataViewset
     queryset = NiceDocument.objects.all()
     authentication_classes = (TokenAuthentication,)
-    permission_classes = (IsAuthenticated,)
+    permission_classes = (IsAuthenticated, DenyGuestUserMutationPermission)
     get_request_user_regions = RegionRestrictedAdmin.get_request_user_regions
     get_filtered_queryset = RegionRestrictedAdmin.get_filtered_queryset
     filterset_class = PERDocsFilter
@@ -227,7 +227,7 @@ def get_queryset(self):
 class CountryPerStatsViewset(mixins.ListModelMixin, viewsets.GenericViewSet):
     serializer_class = LatestCountryOverviewSerializer
     filterset_class = PerOverviewFilter
-    permission_classes = [IsAuthenticated]
+    permission_classes = [IsAuthenticated, DenyGuestUserMutationPermission]
 
     def get_queryset(self):
         return Overview.objects.select_related("country", "type_of_assessment").order_by("-created_at")
@@ -247,7 +247,7 @@ def get_queryset(self):
 
 
 class ExportPerView(views.APIView):
-    permission_classes = [permissions.IsAuthenticated]
+    permission_classes = [permissions.IsAuthenticated, DenyGuestUserMutationPermission]
 
     content_negotiation_class = SpreadSheetContentNegotiation
 
@@ -535,7 +535,7 @@ class PublicFormPrioritizationViewSet(viewsets.ReadOnlyModelViewSet):
 
 
 class PerOptionsView(views.APIView):
-    permission_classes = [permissions.IsAuthenticated]
+    permission_classes = [permissions.IsAuthenticated, DenyGuestUserMutationPermission]
     ordering_fields = "__all__"
 
     @extend_schema(request=None, responses=PerOptionsSerializer)
@@ -554,7 +554,7 @@ def get(self, request, version=None):
 class PerProcessStatusViewSet(viewsets.ReadOnlyModelViewSet):
     serializer_class = PerProcessSerializer
     filterset_class = PerOverviewFilter
-    permission_classes = [permissions.IsAuthenticated]
+    permission_classes = [permissions.IsAuthenticated, DenyGuestUserMutationPermission]
     ordering_fields = "__all__"
     get_request_user_regions = RegionRestrictedAdmin.get_request_user_regions
     get_filtered_queryset = RegionRestrictedAdmin.get_filtered_queryset
@@ -639,7 +639,7 @@ def get_queryset(self):
 class PerAggregatedViewSet(viewsets.ReadOnlyModelViewSet):
     serializer_class = PerProcessSerializer
     filterset_class = PerOverviewFilter
-    permission_classes = [permissions.IsAuthenticated]
+    permission_classes = [permissions.IsAuthenticated, DenyGuestUserMutationPermission]
     ordering_fields = ["assessment_number", "phase", "date_of_assessment"]
     get_request_user_regions = RegionRestrictedAdmin.get_request_user_regions
     get_filtered_queryset = RegionRestrictedAdmin.get_filtered_queryset