Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node-fetch dependency #1283

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Remove node-fetch dependency #1283

merged 1 commit into from
Aug 22, 2024

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Aug 22, 2024

Issue

Starting from Node 20 and 22, all tests pass by replacing node-fetch dependency with the native Node fetch API. Thus, the dependency can be removed.

See also #1267

Solution and steps

  • Remove node-fetch dependency.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

Dependencies

  • @foal/cli
    • node-fetch removed
  • @foal/social
    • node-fetch removed

This was referenced Aug 22, 2024
@LoicPoullain LoicPoullain merged commit 5b2d9b0 into v5-0-0 Aug 22, 2024
2 checks passed
@LoicPoullain LoicPoullain deleted the remove-node-fetch branch August 22, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

1 participant