'punycode` deprecation in node-fetch

[kennbuluma]

If possible, could there be an upgrade to node-fetch version 3 to remedy the punycode deprecation warning?

[LoicPoullain]

Unfortunately, node-fetch v3 requires ESM modules which make the framework not compile. Do you have a message provided with the deprecating warning? What does it say?

[kennbuluma]

I get this message when building or running: `(node:5665) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead. (Use node --trace-deprecation ...` to show where the warning was created).​`. It is no issue during development, but just an inconvenience when running with pm2.

…

________________________________ From: Loïc Poullain ***@***.***> Sent: 30 May 2024 09:56 To: FoalTS/foal ***@***.***> Cc: Kennedy Buluma ***@***.***>; Author ***@***.***> Subject: Re: [FoalTS/foal] 'punycode` deprecation in node-fetch (Issue #1267) Unfortunately, node-fetch v3 requires ESM modules which make the framework not compile. Do you have a message provided with the deprecating warning? What does it say? — Reply to this email directly, view it on GitHub<#1267 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACS5YTEWRO7UM73FLTBH5PDZE3STTAVCNFSM6AAAAABIHCJXEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZZGA4DCMRZHE>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[LoicPoullain]

Thanks for the clarification.

I think we can leave things as they are for now. Upgrading to v3 is not possible due to the need to support ES modules and switching to another library would require some work.

In the next major release of Foal, the framework will internally use the native implementation of the fetch API instead. We'll have to wait for Foal v5 and the abandonment of Node 18 support for this. Node 18 causes problems during testing with the native fetch (see note here).

[LoicPoullain]

#1283