Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free esmpy of >=8.6.0 pin and pin iris-grib >=0.20.0 #2542

Merged
merged 7 commits into from
Oct 7, 2024

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 3, 2024

Description

Closes #2535

Long story short:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@valeriupredoi valeriupredoi added the installation Installation problem label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (5b28372) to head (672b376).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2542   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files         251      251           
  Lines       14295    14295           
=======================================
  Hits        13566    13566           
  Misses        729      729           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valeriupredoi
Copy link
Contributor Author

OK @schlunma - you should be fine with an unpinned esmf/esmpy and iris-grib>=0.20.0 - even NCL installs fine (...) but if we want to build a package with any Python <3.12 and NCL then we'd have to pin importlib_metadata <8 as per ESMValGroup/ESMValTool#3700 - we did that for ESMValTool in the last release, so it's no biggie. TL;DR if you happy you can merge this 🍺

@valeriupredoi
Copy link
Contributor Author

(...) = ncl build h7cb714c_54 which the latest build ☺️

environment.yml Outdated Show resolved Hide resolved
Co-authored-by: Manuel Schlund <[email protected]>
@valeriupredoi
Copy link
Contributor Author

@schlunma cheers Manu, go ahead and merge at will 🍺

@schlunma schlunma added this to the v2.12.0 milestone Oct 7, 2024
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks V!!

@schlunma schlunma merged commit 97de18d into main Oct 7, 2024
7 checks passed
@schlunma schlunma deleted the free_esmpy_pin_iris-grib branch October 7, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest iris-grib v0.20.0 conflicts with ncl and esmpy>=8.6.0
2 participants