-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Free esmpy of >=8.6.0
pin and pin iris-grib >=0.20.0
#2542
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2542 +/- ##
=======================================
Coverage 94.90% 94.90%
=======================================
Files 251 251
Lines 14295 14295
=======================================
Hits 13566 13566
Misses 729 729 ☔ View full report in Codecov by Sentry. |
OK @schlunma - you should be fine with an unpinned esmf/esmpy and iris-grib>=0.20.0 - even NCL installs fine (...) but if we want to build a package with any Python <3.12 and NCL then we'd have to pin importlib_metadata <8 as per ESMValGroup/ESMValTool#3700 - we did that for ESMValTool in the last release, so it's no biggie. TL;DR if you happy you can merge this 🍺 |
(...) = ncl build h7cb714c_54 which the latest build |
Co-authored-by: Manuel Schlund <[email protected]>
@schlunma cheers Manu, go ahead and merge at will 🍺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks V!!
Description
Closes #2535
Long story short:
iris-grib
needs be pinned due to Add support for native ERA5 data in GRIB format #2178ncl
has a hard pinesmf<8.6.0
so whateverncl
gets installed foresmf/esmpy>=8.6.0
is about two years old (still 6.6.2 but a very old build, that did not have the pin in)esmf/esmpy<8.6.0
ie8.4.2
as per Is the fix from PR 353 compatible with esmpy<8.6.0 as well? SciTools/iris-esmf-regrid#415Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: