Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python=3.12 #3501

Merged
merged 75 commits into from
Oct 9, 2024
Merged

Add support for Python=3.12 #3501

merged 75 commits into from
Oct 9, 2024

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jan 18, 2024

Long term issue: not affecting too badly now

Previous issues

Also closes #3642

@valeriupredoi
Copy link
Contributor Author

@ESMValGroup/technical-lead-development-team we are inching closer to suppoert Python=3.12 - have a look here https://github.com/ESMValGroup/ESMValTool/actions/runs/8453069262/job/23154935341?pr=3501 - only 4 dependencies need to be rebuilt fro 3.12 - I am a bit at a deadend with prospector though, been waiting on my PR to be merged there since last November; the psy- pkgs I believe that will be updated soon, will go pinch Philipp there; the 🐘 in the room is NCL - am gonna go see what's the atmosphere there; and the pesky one is r-akima - we need to unpin it! 🍺

@valeriupredoi
Copy link
Contributor Author

OK the issue with NCL is not as bad as I thought - it's compatibility with later proj's see NCAR/ncl#210

@valeriupredoi
Copy link
Contributor Author

valeriupredoi commented Apr 8, 2024

note to self: rerun tests sooner than later, psy-maps only made it to conda-forge just about an hour ago

done 🥳

environment.yml Outdated Show resolved Hide resolved
environment.yml Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@valeriupredoi
Copy link
Contributor Author

valeriupredoi commented Oct 9, 2024

@bouweandela you a ⭐ for reviewing, cheers 🍺 Since this is a fairly important PR, I plugged in the review suggestions and did it with "done in xxxcommit" a la carte 😁

@valeriupredoi
Copy link
Contributor Author

@bouweandela @schlunma
Screenshot from 2024-10-09 14-59-40

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻 🍻 🍻

@valeriupredoi
Copy link
Contributor Author

wooooooooo many thanks @bouweandela @schlunma @Chilipp and everyone else who helped with this 🍻 🍻

@valeriupredoi valeriupredoi merged commit 1d3dbd4 into main Oct 9, 2024
6 of 7 checks passed
@valeriupredoi valeriupredoi deleted the python312 branch October 9, 2024 17:08
@bouweandela
Copy link
Member

Thank you V, for the massive amount of effort you put into this!

@schlunma
Copy link
Contributor

That's amazing, thanks V!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings during full development installation
4 participants