-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python=3.12 #3501
Conversation
@ESMValGroup/technical-lead-development-team we are inching closer to suppoert Python=3.12 - have a look here https://github.com/ESMValGroup/ESMValTool/actions/runs/8453069262/job/23154935341?pr=3501 - only 4 dependencies need to be rebuilt fro 3.12 - I am a bit at a deadend with |
OK the issue with NCL is not as bad as I thought - it's compatibility with later |
done 🥳 |
@bouweandela you a ⭐ for reviewing, cheers 🍺 Since this is a fairly important PR, I plugged in the review suggestions and did it with "done in xxxcommit" a la carte 😁 |
Co-authored-by: Bouwe Andela <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍻 🍻 🍻
wooooooooo many thanks @bouweandela @schlunma @Chilipp and everyone else who helped with this 🍻 🍻 |
Thank you V, for the massive amount of effort you put into this! |
That's amazing, thanks V!! |
Long term issue: not affecting too badly now
esmpy/esmf >=8.6.0
conflicting in deps withncl
(ncl
has a hard pin on them<8.6.0
in their conda recipe) - see Unpinesmf
and set it to free like upstream and bump build number conda-forge/ncl-feedstock#155 that doesn't work until NCL fix the issue withesmf
upstream (I'd do it myself, but I got absolutely no clues how to, did open an issue tho Support for esmf >=8.6.0 NCAR/ncl#213); NCL is installed and it is the latest, butesmf/esmpy==8.4.2
which is finePrevious issues
Once Add support for Python=3.12 ESMValCore#2228 *allowing support for Python=3.12 in ESMValCore), we should see what roadblocks we have here, so am starting early. That Core PR is currently roadblocked only byprospector
not being Python=3.12-compatible, but we're working on that.prospector issuenot if we dropprospector
as we did in ESMValCorepsy-reg
needs attention see Rebuild for python312 conda-forge/psy-reg-feedstock#18esmvalcore (prospector is the only roadblock there)ncl -> issue with builds against laterproj
's (>=9.3.1) support forproj >=9.3.1
NCAR/ncl#210r-akima needs unpinnedunpinr-akima
#3564psy- suite (also at install point they need to move from SafeConfigParser to regular parser, viaAttributeError: module 'configparser' has no attribute 'SafeConfigParser'
- SafeConfigParser has now been fully retired in 3.12)psy-stuff has now been updated to support 3.12 via @Chilipp good work, see Rebuild for python312 conda-forge/psyplot-feedstock#27 - exceptpsy-reg
which still needs a rebuild (with Philipp's new infrastructure)prospector (direct dep here, and as we have it via esmvalcore) - needs update some dependency pins so we can build with Python=3.12 prospector-dev/prospector#645 that, in turn, needs a fix/workaround ofmaster
proposed in Mechanical fix/workaround fortests/tools/pyroma/test_pyroma_tool.py
prospector-dev/prospector#658Also closes #3642