Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'crm sbd' sub-level (jsc#PED-8256) #1491

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Add 'crm sbd' sub-level (jsc#PED-8256) #1491

wants to merge 29 commits into from

Commits on Nov 25, 2024

  1. Dev: utils: Introduced detect_duplicate_device_path function in utils 

    - A new function `detect_duplicate_device_path` has been added to `utils.py`.
- This function checks for duplicated device paths in a given list of devices,
  raising a ValueError if duplicates are found.
    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    1a3ce1b View commit details
    Browse the repository at this point in the history

  2. Dev: ui_sbd: Add new 'crm sbd' sublevel (jsc#PED-8256) 

    ** Motivation
The main configurations for sbd use cases are scattered among sysconfig,
on-disk meta data, CIB, and even could be related to other OS components
eg. coredump, SCSI, multipath.

It's desirable to reduce the management complexity among them and to
streamline the workflow for the main use case scenarios.

** Changed include
**** Disk-based SBD scenarios
1. Show usage when syntax error
2. Completion
3. Display SBD related configuration (UC4 in PED-8256)
4. Change the on-disk meta data of the existing sbd disks (UC2.1 in
   PED-8256)
5. Add a sbd disk with the existing sbd configuration (UC2.2 in
   PED-8256)
6. Remove a sbd disk (UC2.3 in PED-8256)
7. Remove sbd from cluster
8. Replace the storage for a sbd disk (UC2.4 in PED-8256)]
9. display status (focusing on the runtime information only) (UC5 in
   PED-8256)

**** Disk-less SBD scenarios
1. Show usage when syntax error (diskless)
2. completion (diskless)
3. Display SBD related configuration (UC4 in PED-8256, diskless)
4. Manipulate the basic diskless sbd configuration (UC3.1 in PED-8256)
    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    4856ee7 View commit details
    Browse the repository at this point in the history

  3. Dev: behave: Adjust functional test for previous changes

    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    1f56ed8 View commit details
    Browse the repository at this point in the history

  4. Dev: doc: Add help info for crm sbd sublevel

    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c5adeed View commit details
    Browse the repository at this point in the history

  5. Dev: ui_sbd: Add property/sysconfig section header for sbd configure … 

    …show
    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    4c93b3d View commit details
    Browse the repository at this point in the history

  6. Dev: ui_sbd: No need to consider static case when calling crm configu… 

    …re show

After PR#1540 got merged, crmsh will load CIB_file env before calling
above readonly command.
    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    dc76bda View commit details
    Browse the repository at this point in the history

  7. Dev: ui_sbd: Catch both stderr and stdout for crm resource status 

    since crm_resource command will direct message to stderr when resource
is not running
    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    4681854 View commit details
    Browse the repository at this point in the history

  8. Dev: ui_sbd: Update regex for parsing SBD device by partlabel

    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    b9242cc View commit details
    Browse the repository at this point in the history

  9. Dev: ui_sbd: Clean up existing fence_sbd resource before configure di… 

    …skless SBD
    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    7fd5d96 View commit details
    Browse the repository at this point in the history

  10. Dev: ui_sbd: Minor changes to the code

    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    b3383a9 View commit details
    Browse the repository at this point in the history

  11. Dev: bootstrap: Check if sbd package is installed in the right place 

    Changes:
- Check at the beginning of the bootstrap process
- Check at configure sbd stage in the interactive mode
- Put the sbd not installed message in the constants.py
    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    3294086 View commit details
    Browse the repository at this point in the history

  12. Dev: ui_sbd: Refactor do_status method 

    - Split the method into smaller methods
- Enhance the readability of output
- Print the type of SBD
    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    588022b View commit details
    Browse the repository at this point in the history

  13. Dev: Refactor the code to avoid circular import

    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    96d9d9a View commit details
    Browse the repository at this point in the history

  14. Dev: report: Dump output of 'crm sbd configure show' and 'crm sbd sta… 

    …tus' to the report result
    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    35685f2 View commit details
    Browse the repository at this point in the history

  15. Dev: ui_sbd: No need to specify device="" when trying to modify prope… 

    …rties under diskless sbd
    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    6b5d7eb View commit details
    Browse the repository at this point in the history

  16. Dev: ui_sbd: Add sbd device sub command

    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    84a2db2 View commit details
    Browse the repository at this point in the history

  17. Dev: ui_sbd: Replace sbd remove as sbd disable sub-command

    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    b8395cb View commit details
    Browse the repository at this point in the history

  18. Dev: ui_sbd: Adjust sbd confiure interface 

    After adding sbd device interface to manage devices, related
functionalities inside sbd configure interface should be adjusted
    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    a6b1307 View commit details
    Browse the repository at this point in the history

  19. Dev: ui_sbd: Check if the adding device is already initialized 

    and make sure the metadata is consistent between devices.
    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    9c0e728 View commit details
    Browse the repository at this point in the history

  20. Dev: bootstrap: Add a log info when starting pacemaker.service 

    Add a log message to indicate the start of pacemaker.service.
This helps users understand that the system is not hanging but
is actually starting pacemaker, especially when SBD_DELAY_START
is set and it takes longer to start pacemaker.
    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    e875426 View commit details
    Browse the repository at this point in the history

  21. Dev: ui_sbd: Reuse sbd.SBDManager.restart_cluster_if_possible 

    to avoid duplicate info message.
    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    d3338f3 View commit details
    Browse the repository at this point in the history

  22. Dev: ui_sbd: Check if node is reachable when getting the node list

    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    3c6061c View commit details
    Browse the repository at this point in the history

  23. Dev: sbd: Move constants.SHOW_SBD_START_TIMEOUT_CMD to sbd.py

    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    2ca9e58 View commit details
    Browse the repository at this point in the history

  24. Dev: sh: Add get_rc_output_without_input in ClusterShell 

    to redirect stderr to stdout.
    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    b544027 View commit details
    Browse the repository at this point in the history

  25. Dev: ui_sbd: Replace 'sbd disable' as 'sbd purge' 

    And the `sbd purge` command will also move /etc/sysconfig/sbd to
/etc/sysconfig/sbd.bak on all nodes.
    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    d46228d View commit details
    Browse the repository at this point in the history

  26. Dev: doc: Upadate crm.8.adoc for SBD help text

    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    6f3f767 View commit details
    Browse the repository at this point in the history

  27. Dev: behave: Add sbd_ui.feature to test the crm sbd UI

    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    cfbf1dc View commit details
    Browse the repository at this point in the history

  28. Dev: sbd: Split get_sbd_device_interactive into smaller functions

    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    062a469 View commit details
    Browse the repository at this point in the history

  29. Dev: unittests: Adjust unit test for previous commits

    @liangxin1300
    liangxin1300 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    79535f6 View commit details
    Browse the repository at this point in the history