-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'crm sbd' sub-level (jsc#PED-8256) #1491
Open
liangxin1300
wants to merge
29
commits into
ClusterLabs:master
Choose a base branch
from
liangxin1300:20240614_crm_sbd_sublevel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add 'crm sbd' sub-level (jsc#PED-8256) #1491
liangxin1300
wants to merge
29
commits into
ClusterLabs:master
from
liangxin1300:20240614_crm_sbd_sublevel
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangxin1300
force-pushed
the
20240614_crm_sbd_sublevel
branch
2 times, most recently
from
July 17, 2024 13:52
338ed50
to
2f10c6e
Compare
Disk-based SBD scenarios1. Show usage when syntax error
More syntax errror cases 2. Completion
3. Display SBD related configuration (UC4 in PED-8256)
4. Change the on-disk meta data of the existing sbd disks (UC2.1 in PED-8256)
5. Add a sbd disk with the existing sbd configuration (UC2.2 in PED-8256)
6. Remove a sbd disk (UC2.3 in PED-8256)
7. Purge sbd from cluster
8. Replace the storage for a sbd disk (UC2.4 in PED-8256)
9. display status (focusing on the runtime information only) (UC5 in PED-8256)
10. overwrite case
Disk-less SBD scenarios1. Show usage when syntax error (diskless)
2. completion (diskless)
3. Display SBD related configuration (UC4 in PED-8256, diskless)
4. Manipulate the basic diskless sbd configuration (UC3.1 in PED-8256)
5. Remove diskless sbd from cluster
|
liangxin1300
force-pushed
the
20240614_crm_sbd_sublevel
branch
9 times, most recently
from
July 23, 2024 13:34
a19a863
to
cc0d52a
Compare
liangxin1300
force-pushed
the
20240614_crm_sbd_sublevel
branch
9 times, most recently
from
August 1, 2024 03:16
1456931
to
e8f53af
Compare
liangxin1300
force-pushed
the
20240614_crm_sbd_sublevel
branch
2 times, most recently
from
August 2, 2024 02:50
bc2a1fa
to
229de46
Compare
liangxin1300
force-pushed
the
20240614_crm_sbd_sublevel
branch
6 times, most recently
from
August 20, 2024 02:07
77c1c4f
to
5d17668
Compare
liangxin1300
force-pushed
the
20240614_crm_sbd_sublevel
branch
from
August 20, 2024 14:45
5d17668
to
ce84f84
Compare
** Motivation The main configurations for sbd use cases are scattered among sysconfig, on-disk meta data, CIB, and even could be related to other OS components eg. coredump, SCSI, multipath. It's desirable to reduce the management complexity among them and to streamline the workflow for the main use case scenarios. ** Changed include **** Disk-based SBD scenarios 1. Show usage when syntax error 2. Completion 3. Display SBD related configuration (UC4 in PED-8256) 4. Change the on-disk meta data of the existing sbd disks (UC2.1 in PED-8256) 5. Add a sbd disk with the existing sbd configuration (UC2.2 in PED-8256) 6. Remove a sbd disk (UC2.3 in PED-8256) 7. Remove sbd from cluster 8. Replace the storage for a sbd disk (UC2.4 in PED-8256)] 9. display status (focusing on the runtime information only) (UC5 in PED-8256) **** Disk-less SBD scenarios 1. Show usage when syntax error (diskless) 2. completion (diskless) 3. Display SBD related configuration (UC4 in PED-8256, diskless) 4. Manipulate the basic diskless sbd configuration (UC3.1 in PED-8256)
…re show After PR#1540 got merged, crmsh will load CIB_file env before calling above readonly command.
since crm_resource command will direct message to stderr when resource is not running
Changes: - Check at the beginning of the bootstrap process - Check at configure sbd stage in the interactive mode - Put the sbd not installed message in the constants.py
- Split the method into smaller methods - Enhance the readability of output - Print the type of SBD
…tus' to the report result
…rties under diskless sbd
After adding sbd device interface to manage devices, related functionalities inside sbd configure interface should be adjusted
and make sure the metadata is consistent between devices.
Add a log message to indicate the start of pacemaker.service. This helps users understand that the system is not hanging but is actually starting pacemaker, especially when SBD_DELAY_START is set and it takes longer to start pacemaker.
to avoid duplicate info message.
to redirect stderr to stdout.
And the `sbd purge` command will also move /etc/sysconfig/sbd to /etc/sysconfig/sbd.bak on all nodes.
liangxin1300
force-pushed
the
20240614_crm_sbd_sublevel
branch
from
November 25, 2024 09:21
226c64c
to
774ea69
Compare
liangxin1300
force-pushed
the
20240614_crm_sbd_sublevel
branch
from
November 25, 2024 10:10
774ea69
to
79535f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The main configurations for sbd use cases are scattered among sysconfig,
on-disk meta data, CIB, and even could be related to other OS components
eg. coredump, SCSI, multipath.
It's desirable to reduce the management complexity among them and to
streamline the workflow for the main use case scenarios.
Changed include
Disk-based SBD scenarios
Disk-less SBD scenarios