tigers L.MORA personal site #122
There are no files selected for viewing
Submodule js-adagrams
added at
a9e984
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,9 +4,48 @@ | |||||
| <meta charset="UTF-8"> | ||||||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||||||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||||||
| <link rel = "stylesheet" href = "styles/styles.css"> | ||||||
| <title>Document</title> | ||||||
| <link rel="preconnect" href="https://fonts.googleapis.com"> | ||||||
| <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> | ||||||
| <link href="https://fonts.googleapis.com/css2?family=Shadows+Into+Light&display=swap" rel="stylesheet"> | ||||||
| </head> | ||||||
| <body class="color"> | ||||||
| <ul> | ||||||
| <li> | ||||||
| <a class= "decoration" href = "portfolio.html">PORTFOLIO</a> | ||||||
|
There was a problem hiding this comment. Based on W3 styling guide, it's better practice to not leave space before and after the
Suggested change
|
||||||
| </li> | ||||||
| <li> | ||||||
| <a class= "decoration" href = "index.html">INDEX</a> | ||||||
| </li> | ||||||
| <li> | ||||||
| <a class= "decoration" href = "about.html">ABOUT</a> | ||||||
| </li> | ||||||
|
|
||||||
| </ul> | ||||||
| </nav> | ||||||
| </header> | ||||||
|
There was a problem hiding this comment. You've got a closing |
||||||
| <div class="grid-container"> | ||||||
| <div> | ||||||
|
There was a problem hiding this comment. Let's use |
||||||
| <img class="photos" src="img/IMG_4335.jpg"> | ||||||
| <p></p> | ||||||
| <h1></h1> | ||||||
| </div> | ||||||
| <div> | ||||||
| <img class="photos" src="img/ca.jpg"> | ||||||
| <p></p> | ||||||
| </div> | ||||||
| <div><img class="photos" src="img/pl.jpg"> | ||||||
| <p><MI AMOR><p></div> | ||||||
|
There was a problem hiding this comment. What's happening here? |
||||||
| </div> | ||||||
| <header> | ||||||
|
There was a problem hiding this comment. This should be above its matching closing tag |
||||||
| <h1></h1> | ||||||
|
There was a problem hiding this comment. Even if this is a placeholder waiting for content, add some text to it. |
||||||
|
|
||||||
| <main class= flex-container2> | ||||||
|
There was a problem hiding this comment. Attribute value should always have quotes around it <main class= "flex-container2"> |
||||||
| LILYS PAGE | ||||||
| </main> | ||||||
| <footer> | ||||||
|
|
||||||
| </footer> | ||||||
| </body> | ||||||
| </html> | ||||||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
|
|
||
| .photos{ | ||
| height: 470px; | ||
| width: 470px; | ||
| } | ||
| .grid-container { | ||
| display: grid; | ||
| grid-template-columns: auto auto auto; | ||
| } | ||
|
Comment on lines
+6
to
+9
|
||
|
|
||
| .color{ | ||
| background-color: black; | ||
| color: white; | ||
| font-family: 'Shadows Into Light', cursive; | ||
| font-size: 33px; | ||
| } | ||
| .font{ | ||
| font-stretch: ultra-expanded | ||
| } | ||
| .decoration{ | ||
| text-decoration: none; | ||
| color: white; | ||
| } | ||
| .decoration2{ | ||
| text-decoration: none; | ||
| color: white; | ||
| font-weight: bold; | ||
| } | ||
| .flex-container { | ||
|
|
||
| display: flex; | ||
| justify-content: space-between; | ||
|
|
||
| } | ||
| .flex-container2 { | ||
|
|
||
| display: flex; | ||
| justify-content: center | ||
| } | ||
|
Comment on lines
+29
to
+39
There was a problem hiding this comment. Glad you used some flexbox styling! 👍 |
||
|
|
||
| .gifphotos{ | ||
| height: 250px; | ||
| width: 250px; | ||
| } | ||
Empty file.
Submodule task-list-front-end
added at
97a0f1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be indented over one more time