tigers L.MORA personal site #122
Conversation
| <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> | ||
| <link href="https://fonts.googleapis.com/css2?family=Shadows+Into+Light&display=swap" rel="stylesheet"> | ||
| </head> | ||
| <body> | ||
|
|
||
| <body class="color"> |
There was a problem hiding this comment.
These should be indented over one more time
|
|
||
| </ul> | ||
| </nav> | ||
| </header> |
There was a problem hiding this comment.
You've got a closing header and nav tag, but not an opening one. It's a good idea to run your HTML through a validator to catch these mistakes.
| </nav> | ||
| </header> | ||
| <div class="grid-container"> | ||
| <div> |
There was a problem hiding this comment.
Let's use section rather than div as much as we can
| <p></p> | ||
| </div> | ||
| <div><img class="photos" src="img/pl.jpg"> | ||
| <p><MI AMOR><p></div> |
There was a problem hiding this comment.
What's happening here? p needs a closing tag.
| <div><img class="photos" src="img/pl.jpg"> | ||
| <p><MI AMOR><p></div> | ||
| </div> | ||
| <header> |
There was a problem hiding this comment.
This should be above its matching closing tag
| </li> | ||
| </ul> | ||
| </nav> | ||
| <center><h1>LILIAN ASHLEY MORA</h1></center> |
There was a problem hiding this comment.
center is going out of style and should be replaced with the css styling rule text-align: center
| <div>FOODIE</div> | ||
|
|
||
| <div>TRAVEL</div> | ||
| <div>MUSIC</div> |
There was a problem hiding this comment.
div is used to divide elements, not display text. So let's put FOODIE and such inside a heading or paragraph tag inside the div. Or even better, replace div with section
| <img class="photos" src="img/github.gif"> | ||
| </div> | ||
| <div class="flex-container2"> | ||
| <Ol> |
| .grid-container { | ||
| display: grid; | ||
| grid-template-columns: auto auto auto; | ||
| } |
| .flex-container { | ||
|
|
||
| display: flex; | ||
| justify-content: space-between; | ||
|
|
||
| } | ||
| .flex-container2 { | ||
|
|
||
| display: flex; | ||
| justify-content: center | ||
| } |
There was a problem hiding this comment.
Glad you used some flexbox styling! 👍
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions