This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
Fixes #155 : Modified widget to use NarrowFilter #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated message from Dropbox CLA bot @rhari991, it looks like you've already signed the Dropbox CLA. Thanks! |
saketkumar
reviewed
Mar 5, 2017
| switch (from) { | ||
| //These values present in R.arrays.from_values | ||
| case "today": | ||
| return "timestamp BETWEEN DATE('now') AND DATE('now', '+1 day')"; | ||
| break; |
There was a problem hiding this comment.
Why are you removing this?
There was a problem hiding this comment.
The Calendar.getInstance() method returns a Calendar object with the current date, so in case the minimum date is today, there is no need to modify it.
| try { | ||
| Log.i("ZULIP_WIDGET", "onDataSetChanged() = Data reloaded"); |
There was a problem hiding this comment.
Create a TAG filed in the class and use that as a parameter of Log.d
|
Nice work! resolve the merge conflicts too. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Modified NarrowFilterByDate to have a minimum date option and used that in the widget.
For #155
Please make sure these boxes are checked before submitting your pull request - thanks! Guide
Code is formatted.
Run the lint tests with
./gradlew lintDebugand make sure BUILD is SUCCESSFULIf new feature is implemeted then it is compatible with Night theme too.
Commit messages are well-written.