-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoload and emulate zsh
#758
base: master
Are you sure you want to change the base?
Conversation
6449f17
to
d38ba1d
Compare
Tests pass on |
Tests pass on `3423a97 driver: Split out autoloadable part of _zsh_highlight`, but fail on `ef754de driver: Run under emulate zsh`. I believe this is due to defining a function under emulate being sticky, but will need to further investigate later.
Noted. Let me know when you'd like me to run tests under master.
|
I mean, under zsh master. :)
|
Skimmed. It's very comprehensive. Much kudos! Let me know how I can help. It's an invasive change so I'll definitely prefer to merge it before a release rather than after, to ease backports, should any be needed. I take it you're targeting this branch for 0.8.0. (I don't have a strong opinion one way or the other.) |
5e45f0f
to
a8b9480
Compare
Upon further testing, while tests may pass, interactively options that are reset by Still need to add the fallback code if |
Travis is failing on pre-5.3 zsh with several different warnings. I didn't check whether some of these happen on 5.3-and-later too, which are green.
|
Tested under zsh zsh-5.8-177-gd14a924 and zsh-5.8-241-g7facca6. All tests pass under both. Starting the latter interactively, sourcing z-sy-h, unsetting EQUALS, then typing |
@danielshahaf @phy1729 What are the remaining blockers for this to be merged? |
Since redrawhook is now merged, figured I'd start the autoload highlighters and emulate zsh source driver branch.
Still appears to work locally (including
setopt interactivecomments
and then typing a line with comments). I'm running 5.8 though, so tests with a dev version with redrawhook active are needed.Related issues: #252 #536 #688