Highlight escaped reserved words properly #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (with slightly different settings) if path expansion returned the input unchanged. In particular, note that applying all but the last hunk of this diff would cause «time» in command position to be highlighted as «command» rather than «reserved». (This is covered by tests.)
danielshahaf
force-pushed
the
reswords-escaped-v1
branch
from
37d4ed0
to
5fd2ae8
Compare
danielshahaf
commented
Mar 19, 2020
| @@ -153,19 +153,17 @@ _zsh_highlight_main_calculate_fallback() { | |||
| # | |||
| # If $2 is 0, do not consider aliases. | |||
| # | |||
| # If $3 is 0, do not consider reserved words. | |||
| # | |||
There was a problem hiding this comment.
A call to this function was added to master after this branch was crested created. See whether it should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #701.
There's a TODO in the last commit.