Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

veredise audit fix: bh= may occur in other DKIM tags #23

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jp4g
Copy link
Contributor

@jp4g jp4g commented Nov 28, 2024

Addresses Veridise Audit Issue: "bh= may occur in other DKIM tags"

Solution:

  1. adds a check for prefix of "; bh=" instead of "bh=" when accessing body hash from dkim-header field
  2. adds a check for suffix ";" (no suffix check previously) when accessing body hash from dkim-header field

Includes a test with crafted dkim-signature field that should otherwise have passed old get_body_hash check but now fails

Stack order: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant