Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Changes PR #956

Merged
merged 10 commits into from
Nov 20, 2024
Merged

Header Changes PR #956

merged 10 commits into from
Nov 20, 2024

Conversation

sania-16
Copy link
Contributor

Screenshot 2024-11-13 at 5 30 52 PM

@sania-16 sania-16 changed the title Header Changes #602 PR Header Changes PR Nov 13, 2024
Copy link
Member

@sonalgoyal sonalgoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

public void printAnalyticsBanner(boolean collectMetrics) {
LOG.info("**************************************************************************");
LOG.info("* *");
LOG.info("* "+getProductName()+" *");

Check warning

Code scanning / PMD

Logger calls should be surrounded by log level guards. Warning

Logger calls should be surrounded by log level guards.
LOG.info("* *");
LOG.info("* https://www.zingg.ai/ *");
LOG.info("* *");
LOG.info("* using: Zingg v"+getProductVersion()+" *");

Check warning

Code scanning / PMD

Logger calls should be surrounded by log level guards. Warning

Logger calls should be surrounded by log level guards.
import zingg.common.core.executor.verifyblocking.IVerifyBlockingPipeUtil;
import zingg.common.core.executor.verifyblocking.VerifyBlocking;
import zingg.common.core.executor.verifyblocking.VerifyBlockingPipes;
import zingg.common.core.executor.blockingverifier.*;

Check warning

Code scanning / PMD

Unused import 'zingg.common.client.util.*' Warning test

Unused import 'zingg.common.core.executor.blockingverifier.*'
@sonalgoyal sonalgoyal merged commit b151cfd into zinggAI:main Nov 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants