Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler-rt: Fix R_ARM_ABS32 relocation error in __clzsi2_thumb1(). #22051

Merged
merged 1 commit into from
Nov 23, 2024
Merged

compiler-rt: Fix R_ARM_ABS32 relocation error in __clzsi2_thumb1(). #22051

merged 1 commit into from
Nov 23, 2024
+2 −2

Conversation

alexrp
Copy link
Member

@alexrp alexrp commented Nov 23, 2024

Closes #22050.

@alexrp alexrp enabled auto-merge (rebase) November 23, 2024 12:45
@ikskuh
Copy link
Contributor

ikskuh commented Nov 23, 2024

I think we should add a regression test which compiles some PIE for thumb-freestanding so we don't get the behaviour back

@alexrp
Copy link
Member Author

alexrp commented Nov 23, 2024

Well, we need PIE tests for all targets in general. I never did get around to adding those after the port work I did in std.os.linux.pie.

@alexrp
Copy link
Member Author

alexrp commented Nov 23, 2024

#22052

@alexrp alexrp merged commit 2742ab4 into ziglang:master Nov 23, 2024
10 checks passed
@alexrp alexrp deleted the clzsi2-thumb-fix branch November 23, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

__clzsi2_thumb1() fails to link due to R_ARM_ABS32 relocation error with PIC
2 participants
@alexrp @ikskuh