Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement #4442 , goctl generate unit test files for api handler and logic #4443

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

studyzy
Copy link

@studyzy studyzy commented Nov 1, 2024

No description provided.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (8690859) to head (d75afbc).
Report is 166 commits behind head on master.

Additional details and impacted files

see 5 files with indirect coverage changes

---- 🚨 Try these New Features:

@kesonan
Copy link
Collaborator

kesonan commented Nov 3, 2024

  1. It is required that goctl description for flag goctl api -test, pls reference file tools/goctl/internal/flags/default_en.json

@studyzy
Copy link
Author

studyzy commented Nov 3, 2024

  1. It is required that goctl description for flag goctl api -test, pls reference file tools/goctl/internal/flags/default_en.json

Added in new commit.

@studyzy studyzy requested a review from kesonan November 5, 2024 08:20
@kesonan
Copy link
Collaborator

kesonan commented Nov 19, 2024

image
Please check the template, then generate the code and test whether the code can be compiled. Currently, there is a problem with the template.

@studyzy
Copy link
Author

studyzy commented Nov 25, 2024

image Please check the template, then generate the code and test whether the code can be compiled. Currently, there is a problem with the template.

Update template, fixed this bug! @kesonan

Copy link
Collaborator

@kesonan kesonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @kevwan pls merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants