Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/conf_map_required #4405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/mapping/unmarshaler.go
Original file line number Diff line number Diff line change
Expand Up @@ -908,12 +908,16 @@ func (u *Unmarshaler) processNamedFieldWithoutValue(fieldType reflect.Type, valu
}

switch fieldKind {
case reflect.Array, reflect.Map, reflect.Slice:
case reflect.Array, reflect.Slice:
if !opts.optional() {
return u.processFieldNotFromString(fieldType, value, valueWithParent{
value: emptyMap,
}, opts, fullName)
}
case reflect.Map:
if !opts.optional() {
return newInitError(fullName)
}
case reflect.Struct:
if !opts.optional() {
required, err := structValueRequired(u.key, derefedType)
Expand Down
36 changes: 36 additions & 0 deletions core/mapping/unmarshaler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2325,6 +2325,42 @@ func TestUnmarshalMapOfStruct(t *testing.T) {
}
assert.Error(t, UnmarshalKey(m, &v))
})

t.Run("map set", func(t *testing.T) {
type Inner1 struct {
M map[string]string
}
assert.Error(t, UnmarshalKey(map[string]any{}, &Inner1{}))
assert.NoError(t, UnmarshalKey(map[string]any{
"M": map[string]string{},
}, &Inner1{}))

type Inner2 struct {
Inner1
}
assert.Error(t, UnmarshalKey(map[string]any{}, &Inner2{}))
assert.NoError(t, UnmarshalKey(map[string]any{
"M": map[string]string{},
}, &Inner2{}))

type Inner3 struct {
C Inner1
}
assert.Error(t, UnmarshalKey(map[string]any{}, &Inner3{}))
assert.NoError(t, UnmarshalKey(map[string]any{
"C": map[string]any{
"M": map[string]string{},
},
}, &Inner3{}))

type Inner4 struct {
M map[string]string `json:",optional"`
}
assert.NoError(t, UnmarshalKey(map[string]any{}, &Inner4{}))
assert.NoError(t, UnmarshalKey(map[string]any{
"M": map[string]string{},
}, &Inner4{}))
})
}

func TestUnmarshalSlice(t *testing.T) {
Expand Down