Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactorings #415

Merged
merged 6 commits into from
Jul 7, 2024
Merged

Small refactorings #415

merged 6 commits into from
Jul 7, 2024

Conversation

mmd-osm
Copy link
Collaborator

@mmd-osm mmd-osm commented Jul 6, 2024 •
edited
Loading

  • Split ApiDB_Relation_Updater::lock_future_members into smaller methods
  • RequestContext: removed start_time again, this info is also available as req.get_current_time()
  • Changed (*req_ctx.user).id to req_ctx.user->id for better readability
  • validate_user_db_update_permission: use RequestContext instead of request
  • Switch back to request instead of RequestContext for non POST/PUT methods
  • Some linter fixes

@mmd-osm mmd-osm mentioned this pull request Jul 6, 2024
Merged
@mmd-osm mmd-osm force-pushed the patch/cleanup15 branch 4 times, most recently from c83b1a1 to a486e43 Compare July 6, 2024 10:08
@mmd-osm mmd-osm merged commit 641452b into zerebubuth:master Jul 7, 2024
6 checks passed
@mmd-osm mmd-osm deleted the patch/cleanup15 branch July 13, 2024 08:18
@mmd-osm mmd-osm added this to the v2.0.0 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@mmd-osm