-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for the Adafruit QT Py ESP32-S3 #81857
base: main
Are you sure you want to change the base?
Conversation
b4f6678
to
3e7f203
Compare
This adds support for the ESP32s3 based Adafruit QT Py, as well as its PSRAM variant. Signed-off-by: Ian Wakely <[email protected]>
The Adafruit QT Py ESP32-S3 needs to have GPIO hogs enabled in order to use the onboard RBG LED with the led_strip sample code. Signed-off-by: Ian Wakely <[email protected]>
3e7f203
to
251bd41
Compare
line-idle-low; | ||
|
||
led_strip: ws2812@0 { | ||
compatible = "worldsemi,ws2812-spi"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too much indent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
globally or specifically right here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I see it now. this whole section.
socs: | ||
- name: esp32s3 | ||
variants: | ||
- name: 'psram' | ||
cpucluster: 'procpu' | ||
- name: 'psram' | ||
cpucluster: 'appcpu' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this comes in 2 designs then it should be using hardware versions not variants unless you mean there is only 1 board and you can pick if you use the psram or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adafruit offers 2 boards with the same name, with the only difference being that one has "with PSRAM" in the name. The best I can tell, they use the same schematic and use a BOM swap to have the different SOCs placed in manufacturing.
Both products are still in active production:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the boards aren't revisions of each other, they are distinct products and don't fall into a semantic versioning scheme. Unless you're trying to suggest that using the amount of flash a board has should be using the revision scheme?
This adds support for the Adafruit QT Py ESP32-S3 board for both the "non-psram" variant as well as the "with psram" variant. The QT Py ecosystem is designed to be compatible with Seeedstudio's Xiao ecosystem, while bringing integration with the rest of Adafruit's STEMMA QT system.