-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluetooth: Host: deprecate bt_le_set_auto_conn() #81757
base: main
Are you sure you want to change the base?
Bluetooth: Host: deprecate bt_le_set_auto_conn() #81757
Conversation
17413f7
to
95068cc
Compare
doc/releases/release-notes-4.1.rst
Outdated
* Deprecated the :c:func:`bt_le_set_auto_conn` API function. Application developers can achieve | ||
the same functionality in their application code by reconnecting to the peer when the | ||
:c:member:`bt_conn_cb.disconnected` callback is invoked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this should be here or under the Bluetooth Host section. Looking at previous release notes it seems that we put deprecation there. And it seems that some subsystem do the same.
@kartben do you have any recommendation on what we should do there?
21eb9f1
95068cc
to
21eb9f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some formatting that should be fixed.
w.r.t. where it should be placed in the release notes/migration guide, I think it belongs in the release notes. If there is a way to migrate to something else, that should be an entry in the migration guide as well.
Whether to put in Deprecated in this release
or under Bluetooth, that's a bit unclear. We've seemingly done both at random over the years, but I think Deprecated in this release
is the best place for it
bt_le_set_auto_conn() function is not working as expected. Also, it doesn't have any test coverage and any usage in sample applications. The function is deprecated Fixes zephyrproject-rtos#81597 Signed-off-by: Ivan Iushkov <[email protected]>
21eb9f1
to
08bf789
Compare
bt_le_set_auto_conn() function is not working as
expected. Also, it doesn't have any test coverage
and any usage in sample applications.
The function is deprecated
Fixes #81597