Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: Host: deprecate bt_le_set_auto_conn() #81757

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ivaniushkov
Copy link
Member

bt_le_set_auto_conn() function is not working as
expected. Also, it doesn't have any test coverage
and any usage in sample applications.
The function is deprecated
Fixes #81597

rugeGerritsen
rugeGerritsen previously approved these changes Nov 22, 2024
jhedberg
jhedberg previously approved these changes Nov 22, 2024
Comment on lines 33 to 35
* Deprecated the :c:func:`bt_le_set_auto_conn` API function. Application developers can achieve
the same functionality in their application code by reconnecting to the peer when the
:c:member:`bt_conn_cb.disconnected` callback is invoked.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this should be here or under the Bluetooth Host section. Looking at previous release notes it seems that we put deprecation there. And it seems that some subsystem do the same.

@kartben do you have any recommendation on what we should do there?

rugeGerritsen
rugeGerritsen previously approved these changes Nov 22, 2024
@ivaniushkov ivaniushkov force-pushed the bluetooth_host_deprecate_bt_le_set_auto_conn branch from 95068cc to 21eb9f1 Compare November 25, 2024 07:52
Copy link
Collaborator

@Thalley Thalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some formatting that should be fixed.

w.r.t. where it should be placed in the release notes/migration guide, I think it belongs in the release notes. If there is a way to migrate to something else, that should be an entry in the migration guide as well.

Whether to put in Deprecated in this release or under Bluetooth, that's a bit unclear. We've seemingly done both at random over the years, but I think Deprecated in this release is the best place for it

doc/releases/release-notes-4.1.rst Outdated Show resolved Hide resolved
include/zephyr/bluetooth/conn.h Outdated Show resolved Hide resolved
bt_le_set_auto_conn() function is not working as
expected. Also, it doesn't have any test coverage
and any usage in sample applications.
The function is deprecated
Fixes zephyrproject-rtos#81597

Signed-off-by: Ivan Iushkov <[email protected]>
@ivaniushkov ivaniushkov force-pushed the bluetooth_host_deprecate_bt_le_set_auto_conn branch from 21eb9f1 to 08bf789 Compare November 25, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Breaking API Change: Bluetooth: Host: bt_le_set_auto_conn deprecation
7 participants