Bluetooth: Host: Deprecate BT_BUF_ACL_RX_COUNT symbol
#81747
+65
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theob-pro
force-pushed
the
deprecate-bt-buf-acl-rx-count
branch
from
9d08004
to
195310d
Compare
theob-pro
changed the title
BT_BUF_ACL_RX_COUNT symbol
theob-pro
force-pushed
the
deprecate-bt-buf-acl-rx-count
branch
from
195310d
to
29f6d3c
Compare
theob-pro
added
Enhancement
zephyrbot
added
area: Bluetooth Mesh
area: Bluetooth Qualification
zephyrbot
requested review from
alwa-nordic,
carlescufi,
cvinayak,
erbr-ot,
hermabe,
jhedberg,
kartben,
kruithofa,
mtpr-ot,
nashif,
rugeGerritsen,
sjanc,
Thalley,
thoh-ot and
wopu-ot
jhedberg
requested changes
Nov 22, 2024
theob-pro
force-pushed
the
deprecate-bt-buf-acl-rx-count
branch
from
29f6d3c
to
744924d
Compare
cvinayak
requested changes
Nov 22, 2024
Comment on lines
+88
to
+89
| By default, the number of incoming ACL data buffers is equal to | ||
| CONFIG_BT_MAX_CONN + 1. |
There was a problem hiding this comment.
Why is this +1 because SMP needs an MTU of 69, and Controller sends two HCI ACL Data packets towards Host?
There was a problem hiding this comment.
Here is the explanation:
zephyr/include/zephyr/bluetooth/buf.h
Lines 93 to 100 in 744924d
theob-pro
force-pushed
the
deprecate-bt-buf-acl-rx-count
branch
from
744924d
to
d34ac1a
Compare
jhedberg
reviewed
Nov 25, 2024
Because the number of ACL RX buffers must be at least the number of maximum connections plus one, increasing `CONFIG_BT_MAX_CONN` could inadvertently lead to a build failure if the number of ACL RX buffers is not also increased. This dependency may not be obvious to users. To address this issue, this commit deprecates the `CONFIG_BT_BUF_RX_COUNT` Kconfig symbol and computes the value in `buf.h` using the new `BT_BUF_RX_COUNT` define. Note that the default value and the minimum range value have been changed to 0 to "disable" the option. Additionally, to allow users to increase the number of ACL RX buffers, this commit introduces the new `CONFIG_BT_BUF_RX_COUNT_EXTRA` Kconfig symbol. The value of this symbol will be added to the computed value of `BT_BUF_RX_COUNT`. The configurations of tests and samples have been updated to reflect these changes. Signed-off-by: Théo Battrel <[email protected]>
theob-pro
force-pushed
the
deprecate-bt-buf-acl-rx-count
branch
from
d34ac1a
to
f2ba815
Compare
jhedberg
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the number of ACL RX buffers must be at least the number of maximum connections plus one, increasing
CONFIG_BT_MAX_CONNcould inadvertently lead to a build failure if the number of ACL RX buffers is not also increased. This dependency may not be obvious to users.To address this issue, this commit deprecates the
CONFIG_BT_BUF_RX_COUNTKconfig symbol and computes the value inbuf.husing the newBT_BUF_RX_COUNTdefine.Additionally, to allow users to increase the number of ACL RX buffers, this commit introduces the new
CONFIG_BT_BUF_RX_COUNT_EXTRAKconfig symbol. The value of this symbol will be added to the computed value ofBT_BUF_RX_COUNT.The configurations of tests and samples have been updated to reflect these changes.