drivers: ethernet: renesas: Support Renesas RA8 Ethernet driver #77850

thaoluonguw · 2024-09-01T06:15:20Z

This PR is to support Ethernet driver for the Renesas RA8 boards
The driver design is based on the using Ethernet and Ethernet PHY FSP driver from hal_renesas to implement.

zephyrbot · 2024-09-01T06:16:18Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_renesas	zephyrproject-rtos/hal_renesas@`1032651` (`main`)	zephyrproject-rtos/hal_renesas#34	zephyrproject-rtos/hal_renesas#34/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

decsny · 2024-09-23T19:17:57Z

dts/bindings/ethernet/renesas,ra-ethernet.yaml

+  interrupts:
+    required: true
+
+  phy-type:


This is too similar to the generic phy-connection-type. Also I don't think it's a good idea to have an enum of a bunch of different specific phy devices. The phy should be a separate node in DT if it is a separate device in hardware.

@decsny , Changed to phy-connection-type

decsny · 2024-09-23T19:18:56Z

dts/arm/renesas/ra/ra8/ra8x1.dtsi

+			reg = <0x40354100 0xfc>;
+			interrupts = <42 0>;
+			local-mac-address = [00 11 22 33 44 55];
+			phy-type = <RA_PHY_ICS1894>;


some info specific external phy doesn't belong in an soc devictree, unless that phy is embedded in the soc

@decsny , Thank you for you feedback, now we are using phy node

decsny · 2024-09-23T19:20:05Z

drivers/ethernet/eth_renesas_ra.c

+				}
+			}
+		} else if (res == -EAGAIN) {
+			res = R_ETHER_LinkProcess(&ctx->ctrl);


should be using zephyr phy API in the driver, no new vendor hal phy apis please, users hate this

@decsny , Thank you for you feedback, we change to implement mdio driver and now is using phy API from Zephyr, could you please help to recheck

samples/net/cloud/aws_iot_mqtt/boards/ek_ra8m1.overlay

samples/net/dhcpv4_client/boards/mck_ra8t1.conf

drivers/ethernet/Kconfig.renesas_ra

samples/net/cloud/aws_iot_mqtt/boards/mck_ra8t1.conf

maass-hamburg · 2024-10-31T14:07:41Z

samples/net/cloud/aws_iot_mqtt/boards/ek_ra8m1.conf

+# Copyright (c) 2024 Renesas Electronics Corporation
+# SPDX-License-Identifier: Apache-2.0
+
+CONFIG_ENTROPY_DEVICE_RANDOM_GENERATOR=y


this is on by default, if the device supports it. so no need to enable it explicit.

Thank you, I rebase the change and remove the commit for this.

maass-hamburg · 2024-10-31T14:12:16Z

samples/net/cloud/aws_iot_mqtt/boards/ek_ra8m1.conf

+CONFIG_ENTROPY_DEVICE_RANDOM_GENERATOR=y
+
+CONFIG_NET_DHCPV4=y
+CONFIG_NET_DHCPV4_INITIAL_DELAY_MAX=2


is it necessary to set this to 2 instead using the default of 10?

Thank you, I rebase the change and remove the commit for this.

maass-hamburg · 2024-11-21T07:44:21Z

samples/net/cloud/aws_iot_mqtt/boards/ek_ra8d1.conf

+# Copyright (c) 2024 Renesas Electronics Corporation
+# SPDX-License-Identifier: Apache-2.0
+
+CONFIG_ENTROPY_DEVICE_RANDOM_GENERATOR=y


with #80677 merged, this file and the other board specific files are no longer needed for that sample.

@maass-hamburg , Thank you, I rebase the change and remove the commit for this.

Add support for mdio driver for Renesas RA MCU series This support utilize the r_ether_phy driver in hal renesas to support mdio write and read function Signed-off-by: Duy Nguyen <[email protected]>

The ICS1894 phy AN_COMPLETE bit is latched high, this make the BMSR first read return incorrect status of the AN state, update one more BMSR read to ensure all latched bit is clear and BMSR return actual status of the phy chip Signed-off-by: Duy Nguyen <[email protected]>

This commit is to enable Ethernet drivers support on Renesas RA MCU, first target support is the Renesas RA8 series Signed-off-by: Duy Nguyen <[email protected]>

duynguyenxa · 2024-11-21T08:20:13Z

@decsny , could you help to recheck this PR

Enable Ethernet controller node and mdio node for RA boards. Add pinctl for mdio and Ethernet usage Signed-off-by: Duy Nguyen <[email protected]>

Temporary update hal_renesas commit for Ethernet Signed-off-by: Thao Luong <[email protected]>

When publish message, the dup_flag is not intialize causing it to have random value and making the AWS MQTT broker to reject the message Add initialize dup_flag as 0 Signed-off-by: Duy Nguyen <[email protected]>

jukkar · 2024-11-22T06:41:16Z

drivers/ethernet/eth_renesas_ra.c

+
+#define ETHER_ISR_EE_RECEIVE_EVENT_MASK (0x01070000)
+
+#if ((ETHER_TOTAL_BUF_NUM) >= 2)


BTW, you could avoid these long list of conditional variable declarations by using LISTIFY() macro. It would make the code a bit more readable by avoiding this repetitive code.

zephyrbot added manifest manifest-hal_renesas DNM This PR should not be merged (Do Not Merge) labels Sep 1, 2024

thaoluonguw changed the title ~~Support renesas ra8 ethernet~~ drivers: ethernet: renesas: Support Renesas RA8 Ethernet driver Sep 1, 2024

thaoluonguw force-pushed the support_renesas_ra8_ethernet branch from 7f2c197 to 46a85e2 Compare September 23, 2024 18:18

thaoluonguw requested review from ydamigos, duynguyenxa, kv2019i and soburi September 23, 2024 18:21

thaoluonguw marked this pull request as ready for review September 23, 2024 18:21

zephyrbot added area: Networking area: Ethernet area: Pinctrl area: Samples Samples platform: Renesas RA Renesas Electronics Corporation, RA labels Sep 23, 2024

zephyrbot requested review from decsny, jukkar, kartben, KhiemNguyenT, lmajewski, maass-hamburg, nashif, pdgendt, rlubos, ssharks and tbursztyka September 23, 2024 18:22

zephyrbot assigned kartben Sep 23, 2024

decsny requested changes Sep 23, 2024

View reviewed changes

duynguyenxa force-pushed the support_renesas_ra8_ethernet branch from 46a85e2 to d34901d Compare October 25, 2024 07:42

zephyrbot added the area: MDIO label Oct 25, 2024

duynguyenxa requested a review from decsny October 25, 2024 07:46

maass-hamburg requested changes Oct 25, 2024

View reviewed changes

duynguyenxa force-pushed the support_renesas_ra8_ethernet branch 3 times, most recently from 446ca92 to d0199df Compare October 29, 2024 04:38

duynguyenxa requested a review from maass-hamburg October 29, 2024 05:06

duynguyenxa force-pushed the support_renesas_ra8_ethernet branch 5 times, most recently from b92bf83 to ac021e5 Compare October 30, 2024 01:48

maass-hamburg reviewed Oct 31, 2024

View reviewed changes

kartben assigned KhiemNguyenT and unassigned kartben Nov 8, 2024

duynguyenxa force-pushed the support_renesas_ra8_ethernet branch from a0c9ead to 7384dd7 Compare November 21, 2024 07:41

maass-hamburg requested changes Nov 21, 2024

View reviewed changes

duynguyenxa added 3 commits November 21, 2024 14:47

drivers: mdio: Initial support for renesas RA mdio driver

249ba26

Add support for mdio driver for Renesas RA MCU series This support utilize the r_ether_phy driver in hal renesas to support mdio write and read function Signed-off-by: Duy Nguyen <[email protected]>

drivers: eth: Initial support for Renesas RA Ethernet driver

ada71e8

This commit is to enable Ethernet drivers support on Renesas RA MCU, first target support is the Renesas RA8 series Signed-off-by: Duy Nguyen <[email protected]>

duynguyenxa force-pushed the support_renesas_ra8_ethernet branch from 7384dd7 to cf598a4 Compare November 21, 2024 08:09

duynguyenxa requested a review from maass-hamburg November 21, 2024 08:19

duynguyenxa and others added 3 commits November 21, 2024 17:00

boards: renesas: ra: Add Ethernet support for RA8 boards

8c9bf49

Enable Ethernet controller node and mdio node for RA boards. Add pinctl for mdio and Ethernet usage Signed-off-by: Duy Nguyen <[email protected]>

manifest: Temporary update hal_renesas commit

dc3532c

Temporary update hal_renesas commit for Ethernet Signed-off-by: Thao Luong <[email protected]>

sample: net: Add initialize for dup_flag when publish

34df366

When publish message, the dup_flag is not intialize causing it to have random value and making the AWS MQTT broker to reject the message Add initialize dup_flag as 0 Signed-off-by: Duy Nguyen <[email protected]>

duynguyenxa force-pushed the support_renesas_ra8_ethernet branch from cf598a4 to 34df366 Compare November 21, 2024 10:01

jukkar reviewed Nov 22, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drivers: ethernet: renesas: Support Renesas RA8 Ethernet driver #77850

drivers: ethernet: renesas: Support Renesas RA8 Ethernet driver #77850

thaoluonguw commented Sep 1, 2024 •

edited

Loading

zephyrbot commented Sep 1, 2024 •

edited

Loading

decsny Sep 23, 2024

duynguyenxa Oct 25, 2024

decsny Sep 23, 2024

duynguyenxa Oct 25, 2024

decsny Sep 23, 2024

duynguyenxa Oct 25, 2024

maass-hamburg Oct 31, 2024

duynguyenxa Nov 21, 2024

maass-hamburg Oct 31, 2024

duynguyenxa Nov 21, 2024

maass-hamburg Nov 21, 2024

duynguyenxa Nov 21, 2024

duynguyenxa commented Nov 21, 2024

jukkar Nov 22, 2024


		#define ETHER_ISR_EE_RECEIVE_EVENT_MASK (0x01070000)

		#if ((ETHER_TOTAL_BUF_NUM) >= 2)

drivers: ethernet: renesas: Support Renesas RA8 Ethernet driver #77850

Are you sure you want to change the base?

drivers: ethernet: renesas: Support Renesas RA8 Ethernet driver #77850

Conversation

thaoluonguw commented Sep 1, 2024 • edited Loading

zephyrbot commented Sep 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

duynguyenxa commented Nov 21, 2024

Choose a reason for hiding this comment

thaoluonguw commented Sep 1, 2024 •

edited

Loading

zephyrbot commented Sep 1, 2024 •

edited

Loading