Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vLLM deployment example #131

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

dudeperf3ct
Copy link
Contributor

@dudeperf3ct dudeperf3ct commented Sep 30, 2024

In this PR, we add an example for using vllm model deployer in zenml.

To test this example, zenml library should be installed from the below PR.

Related zenml PR: zenml-io/zenml#3032

Copy link

dagshub bot commented Sep 30, 2024

@@ -0,0 +1,3 @@
zenml>=0.66.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify zenml version that supports vllm integration.

@safoinme safoinme self-requested a review October 28, 2024 08:06
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add the license here


## 🏃 How to run

In this project, we will deploy the [gpt-2](https://huggingface.co/openai-community/gpt2) model using [vLLM](https://github.com/vllm-project/vllm). Before we're able to run any pipeline, we need to set up our environment as follows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add link to the vllm deployer docs

@htahir1 htahir1 requested a review from safoinme October 29, 2024 09:03
@strickvl
Copy link
Contributor

strickvl commented Nov 5, 2024

@safoinme since we've merged in the integration, let's see if we can get this merged as well? It's linked in the docs, so we can update that when this gets merged in too?

@strickvl strickvl added the enhancement New feature or request label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants